Return-Path: X-Original-To: apmail-ambari-commits-archive@www.apache.org Delivered-To: apmail-ambari-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BCAF1056B for ; Wed, 18 Dec 2013 15:34:38 +0000 (UTC) Received: (qmail 56007 invoked by uid 500); 18 Dec 2013 15:34:37 -0000 Delivered-To: apmail-ambari-commits-archive@ambari.apache.org Received: (qmail 55985 invoked by uid 500); 18 Dec 2013 15:34:36 -0000 Mailing-List: contact commits-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ambari-dev@ambari.apache.org Delivered-To: mailing list commits@ambari.apache.org Received: (qmail 55977 invoked by uid 99); 18 Dec 2013 15:34:35 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2013 15:34:35 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 84FD08E99; Wed, 18 Dec 2013 15:34:35 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: atkach@apache.org To: commits@ambari.apache.org Message-Id: <4bfeb5edac6242b9a82562076a841c18@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: AMBARI-4085 Remove console.logs, which overflow browser console. (atkach) Date: Wed, 18 Dec 2013 15:34:35 +0000 (UTC) Updated Branches: refs/heads/branch-1.4.3 0008a79ed -> fe4412db1 AMBARI-4085 Remove console.logs, which overflow browser console. (atkach) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/fe4412db Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/fe4412db Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/fe4412db Branch: refs/heads/branch-1.4.3 Commit: fe4412db155f166ce19fa7ca99172d0974b2fc97 Parents: 0008a79 Author: atkach Authored: Wed Dec 18 17:34:30 2013 +0200 Committer: atkach Committed: Wed Dec 18 17:34:30 2013 +0200 ---------------------------------------------------------------------- ambari-web/app/controllers/installer.js | 1 - ambari-web/app/controllers/main/admin/security/add/step2.js | 2 -- .../controllers/wizard/stack_upgrade/step3_controller.js | 5 +---- ambari-web/app/controllers/wizard/step10_controller.js | 2 -- ambari-web/app/controllers/wizard/step3_controller.js | 5 ----- ambari-web/app/controllers/wizard/step5_controller.js | 1 - ambari-web/app/controllers/wizard/step8_controller.js | 1 - ambari-web/app/controllers/wizard/step9_controller.js | 9 +-------- ambari-web/app/utils/config.js | 1 - 9 files changed, 2 insertions(+), 25 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/installer.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/installer.js b/ambari-web/app/controllers/installer.js index e9d4410..358542e 100644 --- a/ambari-web/app/controllers/installer.js +++ b/ambari-web/app/controllers/installer.js @@ -104,7 +104,6 @@ App.InstallerController = App.WizardController.extend({ }); this.set('content.services', servicesInfo); console.log('installerController.loadServices: loaded data ', JSON.stringify(servicesInfo)); - console.log("The type odf serviceInfo: " + typeof servicesInfo); console.log('selected services ', servicesInfo.filterProperty('isSelected', true).mapProperty('serviceName')); } else { console.log("Failed to load Services"); http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/main/admin/security/add/step2.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/main/admin/security/add/step2.js b/ambari-web/app/controllers/main/admin/security/add/step2.js index db7ce6a..0065d4b 100644 --- a/ambari-web/app/controllers/main/admin/security/add/step2.js +++ b/ambari-web/app/controllers/main/admin/security/add/step2.js @@ -93,8 +93,6 @@ App.MainAdminSecurityAddStep2Controller = Em.Controller.extend({ this.loadComponentConfigs(_serviceConfig, serviceConfig); - console.log('pushing ' + serviceConfig.serviceName, serviceConfig); - this.get('stepConfigs').pushObject(serviceConfig); }, this); this.set('selectedService', this.get('stepConfigs').filterProperty('showConfig', true).objectAt(0)); http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/stack_upgrade/step3_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/stack_upgrade/step3_controller.js b/ambari-web/app/controllers/wizard/stack_upgrade/step3_controller.js index e05bee2..b85f5a3 100644 --- a/ambari-web/app/controllers/wizard/stack_upgrade/step3_controller.js +++ b/ambari-web/app/controllers/wizard/stack_upgrade/step3_controller.js @@ -485,9 +485,7 @@ App.StackUpgradeStep3Controller = Em.Controller.extend({ * @param host */ setLogTasksStatePerHost: function (tasksPerHost, host) { - console.log('In step3 setTasksStatePerHost function.'); tasksPerHost.forEach(function (_task) { - console.log('In step3 _taskPerHost function.'); var task = host.get('logTasks').findProperty('Tasks.id', _task.Tasks.id); if (task) { host.get('logTasks').removeObject(task); @@ -549,7 +547,6 @@ App.StackUpgradeStep3Controller = Em.Controller.extend({ */ displayMessage: function (task) { var role = App.format.role(task.role); - console.log("In display message with task command value: " + task.command); switch (task.command){ case 'UPGRADE': switch (task.status) { @@ -580,4 +577,4 @@ App.StackUpgradeStep3Controller = Em.Controller.extend({ } } } -}); \ No newline at end of file +}); http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/step10_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/step10_controller.js b/ambari-web/app/controllers/wizard/step10_controller.js index ff8e0cf..3bea6b7 100644 --- a/ambari-web/app/controllers/wizard/step10_controller.js +++ b/ambari-web/app/controllers/wizard/step10_controller.js @@ -70,7 +70,6 @@ App.WizardStep10Controller = Em.Controller.extend({ var hostsInfo = []; for (var index in hosts) { hostsInfo.pushObject(hosts[index]); - console.log('Step10 SUMMARY: value of hosts is: ' + hosts[index].status); } var succeededHosts = hostsInfo.filterProperty('status', 'success'); var warnedHosts = hostsInfo.filterProperty('status', 'warning').concat(hostsInfo.filterProperty('status', 'failed')); @@ -100,7 +99,6 @@ App.WizardStep10Controller = Em.Controller.extend({ } else if (this.get('content.cluster.status') === 'START FAILED') { clusterState = Em.I18n.t('installer.step10.clusterState.starting'); } - console.log('host value is: ' + JSON.stringify(_host)); var failedTasks = _host.tasks.filterProperty('Tasks.status', 'FAILED'); failedTasks.forEach(function (_task) { var taskStatement = clusterState + App.format.role(_task.Tasks.role) + Em.I18n.t('installer.step10.taskStatus.failed') + _host.name; http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/step3_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/step3_controller.js b/ambari-web/app/controllers/wizard/step3_controller.js index 95c2b0c..43050f0 100644 --- a/ambari-web/app/controllers/wizard/step3_controller.js +++ b/ambari-web/app/controllers/wizard/step3_controller.js @@ -155,7 +155,6 @@ App.WizardStep3Controller = Em.Controller.extend({ isChecked: false }); - console.log('pushing ' + hostInfo.name); hosts.pushObject(hostInfo); } @@ -444,11 +443,9 @@ App.WizardStep3Controller = Em.Controller.extend({ break; case 'REGISTERING': if (jsonData.items.someProperty('Hosts.host_name', _host.name)) { - console.log(_host.name + ' has been registered'); _host.set('bootStatus', 'REGISTERED'); _host.set('bootLog', (_host.get('bootLog') != null ? _host.get('bootLog') : '') + Em.I18n.t('installer.step3.hosts.bootLog.registering')); } else { - console.log(_host.name + ' is registering...'); stopPolling = false; } break; @@ -560,7 +557,6 @@ App.WizardStep3Controller = Em.Controller.extend({ if(context) { hostsContext.push(context); } - console.log("The value of memory is: " + _host.memory); } }); if (hostsContext.length > 0) { // warning exist @@ -574,7 +570,6 @@ App.WizardStep3Controller = Em.Controller.extend({ } this.set('repoCategoryWarnings', repoWarnings); this.set('bootHosts', hosts); - console.log("The value of hosts: " + JSON.stringify(hosts)); this.stopRegistration(); }, http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/step5_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/step5_controller.js b/ambari-web/app/controllers/wizard/step5_controller.js index a86c47f..e674c18 100644 --- a/ambari-web/app/controllers/wizard/step5_controller.js +++ b/ambari-web/app/controllers/wizard/step5_controller.js @@ -450,7 +450,6 @@ App.WizardStep5Controller = Em.Controller.extend({ mappedHosts.forEach(function (item) { hostObj = self.get("hosts").findProperty("host_name", item); - console.log("Name of the host is: " + hostObj.host_name); mappingObject = Ember.Object.create({ host_name:item, http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/step8_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/step8_controller.js b/ambari-web/app/controllers/wizard/step8_controller.js index 50a9c66..c0373e5 100644 --- a/ambari-web/app/controllers/wizard/step8_controller.js +++ b/ambari-web/app/controllers/wizard/step8_controller.js @@ -1361,7 +1361,6 @@ App.WizardStep8Controller = Em.Controller.extend({ if (hostNames.length == 0) { return; } - console.log('registering ' + componentName + ' to ' + JSON.stringify(hostNames)); // currently we are specifying the predicate as a query string. // this can hit a ~4000-character limit in Jetty server. http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/controllers/wizard/step9_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/wizard/step9_controller.js b/ambari-web/app/controllers/wizard/step9_controller.js index 0647172..35bd222 100644 --- a/ambari-web/app/controllers/wizard/step9_controller.js +++ b/ambari-web/app/controllers/wizard/step9_controller.js @@ -224,7 +224,6 @@ App.WizardStep9Controller = Em.Controller.extend({ obj.tasks = []; obj.logTasks = []; hosts.add(obj); - console.log("TRACE: host name is: " + hostInfo[index].name); } return hosts.filterProperty('bootStatus', 'REGISTERED'); }, @@ -240,7 +239,6 @@ App.WizardStep9Controller = Em.Controller.extend({ message: _hostInfo.message, progress: _hostInfo.progress }); - console.log('pushing ' + hostInfo.name); this.get('hosts').pushObject(hostInfo); }, this); }, @@ -252,7 +250,6 @@ App.WizardStep9Controller = Em.Controller.extend({ displayMessage: function (task) { var role = App.format.role(task.role); - console.log("In display message with task command value: " + task.command); switch (task.command) { case 'INSTALL': switch (task.status) { @@ -532,7 +529,6 @@ App.WizardStep9Controller = Em.Controller.extend({ progress = 100; break; } - console.log('INFO: progressPerHost is: ' + progress); contentHost.set('progress', progress.toString()); return progress; }, @@ -663,7 +659,6 @@ App.WizardStep9Controller = Em.Controller.extend({ var tasksPerHost = tasksData.filterProperty('Tasks.host_name', _host.name); // retrieved from polled Data if (tasksPerHost !== null && tasksPerHost !== undefined && tasksPerHost.length !== 0) { tasksPerHost.forEach(function (_taskPerHost) { - console.log('In step9 _taskPerHost function.'); _host.tasks.pushObject(_taskPerHost); }, this); } @@ -673,9 +668,7 @@ App.WizardStep9Controller = Em.Controller.extend({ // This is done at HostRole level. setLogTasksStatePerHost: function (tasksPerHost, host) { if (!tasksPerHost) return; - console.log('In step9 setTasksStatePerHost function.'); tasksPerHost.forEach(function (_task) { - console.log('In step9 _taskPerHost function.'); var task = host.logTasks.findProperty('Tasks.id', _task.Tasks.id); if (task) { host.logTasks.removeObject(task); @@ -926,4 +919,4 @@ App.WizardStep9Controller = Em.Controller.extend({ App.router.send('back'); } } -}); \ No newline at end of file +}); http://git-wip-us.apache.org/repos/asf/ambari/blob/fe4412db/ambari-web/app/utils/config.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/utils/config.js b/ambari-web/app/utils/config.js index 004d758..c8a03d1 100644 --- a/ambari-web/app/utils/config.js +++ b/ambari-web/app/utils/config.js @@ -552,7 +552,6 @@ App.config = Em.Object.create({ some of the config defaults to previously user-entered data. **/ tweakDynamicDefaults: function (localDB, serviceConfigProperty, config) { - console.log("Step7: Tweaking Dynamic defaults"); var firstHost = null; for (var host in localDB.hosts) { firstHost = host;