ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yus...@apache.org
Subject svn commit: r1431770 - in /incubator/ambari/trunk: CHANGES.txt ambari-web/app/controllers/main/service/info/configs.js
Date Fri, 11 Jan 2013 00:56:37 GMT
Author: yusaku
Date: Fri Jan 11 00:56:37 2013
New Revision: 1431770

URL: http://svn.apache.org/viewvc?rev=1431770&view=rev
Log:
AMBARI-1151. Reconfigure fails silently; it's not firing any API calls due to a JS error.
(yusaku)

Modified:
    incubator/ambari/trunk/CHANGES.txt
    incubator/ambari/trunk/ambari-web/app/controllers/main/service/info/configs.js

Modified: incubator/ambari/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/CHANGES.txt?rev=1431770&r1=1431769&r2=1431770&view=diff
==============================================================================
--- incubator/ambari/trunk/CHANGES.txt (original)
+++ incubator/ambari/trunk/CHANGES.txt Fri Jan 11 00:56:37 2013
@@ -667,6 +667,9 @@ AMBARI-666 branch (unreleased changes)
 
   BUG FIXES
 
+  AMBARI-1151. Reconfigure fails silently; it's not firing any API calls due
+  to a JS error. (yusaku)
+
   AMBARI-1098. Switching services does not update various UI elements.
   (Srimanth Gunturi via yusaku)
 

Modified: incubator/ambari/trunk/ambari-web/app/controllers/main/service/info/configs.js
URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/ambari-web/app/controllers/main/service/info/configs.js?rev=1431770&r1=1431769&r2=1431770&view=diff
==============================================================================
--- incubator/ambari/trunk/ambari-web/app/controllers/main/service/info/configs.js (original)
+++ incubator/ambari/trunk/ambari-web/app/controllers/main/service/info/configs.js Fri Jan
11 00:56:37 2013
@@ -569,7 +569,10 @@ App.MainServiceInfoConfigsController = E
       if (this.get('globalConfigs').someProperty('name', templateName[index])) {
         //console.log("The name of the variable is: " + this.get('content.serviceConfigProperties').findProperty('name',
templateName[index]).name);
         var globValue = this.get('globalConfigs').findProperty('name', templateName[index]).value;
-        value = value.replace(_express, globValue);
+        // TODO: hack to make reconfig work for now due to some hive params breaking reconfig
in general
+        if (value != null) {
+          value = value.replace(_express, globValue);
+        }
       } else {
         /*
          console.log("ERROR: The variable name is: " + templateName[index]);



Mime
View raw message