Mailing-List: contact ambari-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ambari-dev@incubator.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1346640 - in /incubator/ambari/branches/ambari-186:
 CHANGES.txt
 hmc/js/selectServices.js
Date: Tue, 05 Jun 2012 22:48:27 -0000
To: ambari-commits@incubator.apache.org
From: vikram@apache.org
Message-Id: <20120605224827.A09A52388980@eris.apache.org>

Author: vikram
Date: Tue Jun  5 22:48:27 2012
New Revision: 1346640

URL: http://svn.apache.org/viewvc?rev=1346640&view=rev
Log:
AMBARI-348. Select all services by default  (Contributed by Vinod)

Modified:
    incubator/ambari/branches/ambari-186/CHANGES.txt
    incubator/ambari/branches/ambari-186/hmc/js/selectServices.js

Modified: incubator/ambari/branches/ambari-186/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/ambari/branches/ambari-186/CHANGES.txt?rev=1346640&r1=1346639&r2=1346640&view=diff
==============================================================================
--- incubator/ambari/branches/ambari-186/CHANGES.txt (original)
+++ incubator/ambari/branches/ambari-186/CHANGES.txt Tue Jun  5 22:48:27 2012
@@ -6,6 +6,8 @@ characters wide.
 
 Release 0.1.x - unreleased
 
+  AMBARI-348. Select all services by default (Vinod via Vikram)
+
   AMBARI-247. Replace index.php with clusters.php (Varun via Vikram)
 
   AMBARI-347. Redo master service assignment page (Yusaku via Vikram)

Modified: incubator/ambari/branches/ambari-186/hmc/js/selectServices.js
URL: http://svn.apache.org/viewvc/incubator/ambari/branches/ambari-186/hmc/js/selectServices.js?rev=1346640&r1=1346639&r2=1346640&view=diff
==============================================================================
--- incubator/ambari/branches/ambari-186/hmc/js/selectServices.js (original)
+++ incubator/ambari/branches/ambari-186/hmc/js/selectServices.js Tue Jun  5 22:48:27 2012
@@ -11,6 +11,7 @@ InstallationWizard.SelectServices = {
 };
 
 var data;
+var allBoxesSelected = true;
 
 function renderServiceList(responseJson) {
   data = responseJson;
@@ -67,8 +68,12 @@ function renderServiceList(responseJson)
   globalYui.one("#selectOptionalServicesDynamicRenderDivId").setContent(optionalContent);
   globalYui.one("#selectNonSelectableServicesDynamicRenderDivId").setContent(nonSelectableContent);
   globalYui.one('#selectServicesCoreDivId').setStyle("display", "block");
-}
 
+  // For now, we want all services to be enabled by default
+  selectDelectAll(true);
+  displayStatusOnSelectDeselectAll(true, false);
+  globalYui.one("#selectAllCheckBoxId").set('checked', true);
+}
 
 function generateSelectServiceCheckbox(serviceInfo) {
 
@@ -105,46 +110,164 @@ function generateSelectServiceCheckbox(s
   return dContent;
 }
 
+function getButtonId(serviceName) {
+  return 'installService' + serviceName + 'Id';
+}
+
+function setRefCounts(serviceName) {
+
+  var buttonId = getButtonId(serviceName);
+
+  // Set the refCount for 'this' service
+  if (!globalYui.one('#' + buttonId).get('checked')) {
+     data['services'][serviceName]['refCount'] = 0;
+  } else if (data['services'][serviceName]['refCount'] == 0) {
+     data['services'][serviceName]['refCount'] = 1;
+  }
+
+  // Set the refCounts for 'this' service's dependencies
+  var selectYes = true;
+  if (!globalYui.one('#' + buttonId).get('checked')) {
+     selectYes = false;
+  }
+  for (var i = 0; i < data['services'][serviceName]['dependencies'].length; i++) {
+     var serviceDep = data['services'][serviceName]['dependencies'][i];
+     if (selectYes) {
+        data['services'][serviceDep]['refCount']++;
+     } else {
+        data['services'][serviceDep]['refCount']--;
+        if (data['services'][serviceDep]['refCount'] < 0) {
+           data['services'][serviceDep]['refCount'] = 0;
+        }
+     }
+  }
+}
+
+function displayStatusOnSuccess(serviceName) {
+
+  var buttonId = getButtonId(serviceName);
+
+  var selectYes = true;
+  if (!globalYui.one('#' + buttonId).get('checked')) {
+     selectYes = false;
+  }
+
+  var statusString = "Selected " + data['services'][serviceName].displayName + " for installation. ";
+  if (!globalYui.one('#' + buttonId).get('checked')) {
+     statusString = "Deselected " + data['services'][serviceName].displayName + " and all its dependencies.";
+  }
+  // Generate the status string for dependencies
+  var dependencies = "";
+  for (var i = 0; i < data['services'][serviceName]['dependencies'].length; i++) {
+     var serviceDep = data['services'][serviceName]['dependencies'][i];
+     if (selectYes) {
+        if (!data['services'][serviceDep].attributes.mustInstall) {
+          dependencies += data['services'][serviceDep].displayName + " ";
+        }
+     }
+  }
+  if(selectYes) {
+    if(dependencies != "") {
+      statusString += "Also added  " + dependencies + " as dependencies.";
+    }
+  }
+  setFormStatus(statusString, false);
+}
+
+function updateRendering() {
+
+  var currentAllBoxesSelected = true;
+
+  for (svcName in data['services']) {
+
+     if (data['services'][svcName].attributes.noDisplay) {
+       continue;
+     }
+
+     // globalYui.log('Svc ref count : ' + svcName + ' : ' + data['services'][svcName]['refCount']);
+
+     var itemId = getButtonId(svcName);
+     if (data['services'][svcName].attributes.mustInstall ||
+         data['services'][svcName]['refCount'] > 0) {
+        globalYui.one('#' + itemId).set('checked' ,'yes');
+        if (!data['services'][svcName].attributes.editable) {
+           var divId = 'selectServicesEntry' + svcName + 'DivId';
+           globalYui.one('#' + divId).setStyle('display', '');
+        }
+     } else {
+        currentAllBoxesSelected = false;
+        globalYui.one('#' + itemId).set('checked' ,'');
+        if (!data['services'][svcName].attributes.editable) {
+           var divId = 'selectServicesEntry' + svcName + 'DivId';
+           globalYui.one('#' + divId).setStyle('display', 'none');
+        }
+     }
+  }
+
+  if (allBoxesSelected != currentAllBoxesSelected) {
+    allBoxesSelected = currentAllBoxesSelected;
+    // Update the selectAll button
+    globalYui.one("#selectAllCheckBoxId").set('checked', allBoxesSelected);
+    displayStatusOnSelectDeselectAll(allBoxesSelected, false);
+  }
+}
+
+function displayStatusOnSelectDeselectAll(selectAll, setFormStatusAlso) {
+  var labelNode = globalYui.one("#labelForSelectAllId");
+  if (selectAll) {
+    labelNode.setContent("Deselect all");
+  } else {
+    labelNode.setContent("Select all");
+  }
+  if (setFormStatusAlso) {
+    if (selectAll) {
+      setFormStatus("Selected all services", false);
+  } else {
+    setFormStatus("Deselected all optional services", false);
+  }
+  }
+}
+
+function selectDelectAll(selectAll) {
+  var node = globalYui.one("#selectAllCheckBoxId");
+  var labelNode = globalYui.one("#labelForSelectAllId");
+  for (svcName in data['services']) {
+    if (!data['services'][svcName].attributes.noDisplay && !data['services'][svcName].attributes.mustInstall) {
+      var itemId = getButtonId(svcName);
+      globalYui.one('#' + itemId).set('checked' , selectAll);
+      // Forget about the history and set refCount explicitly
+      if (selectAll) {
+        data['services'][svcName]['refCount'] = 1;
+      } else {
+        data['services'][svcName]['refCount'] = 0;
+      }
+      if (!data['services'][svcName].attributes.editable) {
+         var nonEditableNode = globalYui.one('#selectServicesEntry' + svcName + 'DivId');
+         if (selectAll) {
+           nonEditableNode.setStyle('display', 'block');
+         } else {
+           nonEditableNode.setStyle('display', 'none');
+         }
+      }
+    }
+  }
+}
+
 globalYui.one('#selectServicesCoreDivId').delegate('click', function (e) {
 
     // Select-all checkbox
     if (this.get('id') == 'selectAllCheckBoxId') {
       var node = globalYui.one("#selectAllCheckBoxId");
-      var labelNode = globalYui.one("#labelForSelectAllId");
-      if (node.get('checked')) {
-        labelNode.setContent("Deselect all");
-        setFormStatus("Selected all services", false);
-      } else {
-        labelNode.setContent("Select all");
-        setFormStatus("Deselected all optional services", false);
-      }
-      for (svcName in data['services']) {
-        if (!data['services'][svcName].attributes.noDisplay && !data['services'][svcName].attributes.mustInstall) {
-          var itemId = 'installService' + svcName + 'Id';
-          globalYui.one('#' + itemId).set('checked' , node.get('checked'));
-          // Forget about the history and set refCount explicitly
-          if (node.get('checked')) {
-            data['services'][svcName]['refCount'] = 1;
-          } else {
-            data['services'][svcName]['refCount'] = 0;
-          }
-          if (!data['services'][svcName].attributes.editable) {
-             var nonEditableNode = globalYui.one('#selectServicesEntry' + svcName + 'DivId');
-             if (node.get('checked')) {
-               nonEditableNode.setStyle('display', 'block');
-             } else {
-               nonEditableNode.setStyle('display', 'none');
-             }
-          }
-        }
-      } 
+      var selectAll = node.get('checked');
+      selectDelectAll(selectAll);
+      displayStatusOnSelectDeselectAll(selectAll, true);
       return;
     }
     //// End of select-all checkbox
 
     // globalYui.log(globalYui.Lang.dump(this));
     var serviceName = this.getAttribute('name');
-    var buttonId = 'installService' + serviceName + 'Id';
+    var buttonId = getButtonId(serviceName);
 
     // Deselecting an already selected service
     if (!globalYui.one('#' + buttonId).get('checked')) {
@@ -163,66 +286,18 @@ globalYui.one('#selectServicesCoreDivId'
         globalYui.one('#' + buttonId).set('checked', 'yes');
         return;
       }
-    }
 
-    var selectYes = true;
-    var statusString = "Selected " + data['services'][serviceName].displayName + " for installation. ";
-    if (!globalYui.one('#' + buttonId).get('checked')) {
-       selectYes = false;
-       statusString = "Deselected " + data['services'][serviceName].displayName + " and all its dependencies.";
-       data['services'][serviceName]['refCount'] = 0;
-    } else if (data['services'][serviceName]['refCount'] == 0) {
-       data['services'][serviceName]['refCount'] = 1;
+      // Some things are deselected, so update the selectAll button
+      globalYui.one("#selectAllCheckBoxId").set('checked', false);
     }
 
-    // globalYui.log('selectYes: ' + selectYes);
-    // globalYui.log('serviceName: ' + serviceName);
-
-    var dependencies = "";
-    for (var i = 0; i < data['services'][serviceName]['dependencies'].length; i++) {
-       var serviceDep = data['services'][serviceName]['dependencies'][i];
-       if (selectYes) {
-          data['services'][serviceDep]['refCount']++;
-          if (!data['services'][serviceDep].attributes.mustInstall) {
-            dependencies += data['services'][serviceDep].displayName + " ";
-          }
-       } else {
-          data['services'][serviceDep]['refCount']--;
-          if (data['services'][serviceDep]['refCount'] < 0) {
-             data['services'][serviceDep]['refCount'] = 0;
-          }
-       }
-    }
-    if(selectYes) {
-      if(dependencies != "") {
-        statusString += "Also added  " + dependencies + " as dependencies.";
-      }
-    }
-    setFormStatus(statusString, false);
+    setRefCounts(serviceName);
 
-    for (svcName in data['services']) {
-       if (data['services'][svcName].attributes.noDisplay) {
-         continue;
-       }
+    // Display status as to what we have done now.
+    displayStatusOnSuccess(serviceName);
 
-       // globalYui.log('Svc ref count : ' + svcName + ' : ' + data['services'][svcName]['refCount']);
-     
-       var itemId = 'installService' + svcName + 'Id';
-       if (data['services'][svcName].attributes.mustInstall ||
-           data['services'][svcName]['refCount'] > 0) {
-          globalYui.one('#' + itemId).set('checked' ,'yes');
-          if (!data['services'][svcName].attributes.editable) {
-             var divId = 'selectServicesEntry' + svcName + 'DivId';
-             globalYui.one('#' + divId).setStyle('display', '');
-          }
-       } else {
-          globalYui.one('#' + itemId).set('checked' ,'');
-          if (!data['services'][svcName].attributes.editable) {
-             var divId = 'selectServicesEntry' + svcName + 'DivId';
-             globalYui.one('#' + divId).setStyle('display', 'none');
-          }
-       }
-    }
+    // All done, update our rendering
+    updateRendering();
 
 //}, 'li.selectServicesEntry');
 }, 'input[type=checkbox]');