Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 00DC4200CBD for ; Thu, 6 Jul 2017 21:52:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F391D167472; Thu, 6 Jul 2017 19:52:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 471B116746F for ; Thu, 6 Jul 2017 21:52:23 +0200 (CEST) Received: (qmail 27067 invoked by uid 500); 6 Jul 2017 19:52:22 -0000 Mailing-List: contact dev-help@allura.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@allura.apache.org Delivered-To: mailing list dev@allura.apache.org Received: (qmail 27055 invoked by uid 99); 6 Jul 2017 19:52:22 -0000 Received: from allura-vm.apache.org (HELO allura-vm) (140.211.11.147) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 19:52:22 +0000 Received: from allura-vm.apache.org (localhost [127.0.0.1]) by allura-vm (Postfix) with ESMTPS id 032FC28012A for ; Thu, 6 Jul 2017 19:52:22 +0000 (UTC) Content-Type: multipart/related; boundary="===============6646158616116468851==" MIME-Version: 1.0 To: dev@allura.apache.org From: "Dave Brondsema" Reply-To: "[allura:tickets] " <7896@tickets.allura.p.forge-allura.apache.org> Subject: [allura:tickets] #7896 Better plaintext mail for commit notifications Message-ID:

Sender: tickets@allura.p.forge-allura.apache.org In-Reply-To: <557b24066d19cd1d14ffbfbe.tickets@allura.p.forge-allura.apache.org> References: <557b24066d19cd1d14ffbfbe.tickets@allura.p.forge-allura.apache.org> Date: Thu, 6 Jul 2017 19:52:22 +0000 (UTC) archived-at: Thu, 06 Jul 2017 19:52:24 -0000 --===============6646158616116468851== Content-Type: multipart/alternative; boundary="===============1462717846432453919==" MIME-Version: 1.0 --===============1462717846432453919== MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit - **status**: open --> review - **assigned_to**: Dave Brondsema - **Comment**: Fixed fairly well on db/8157 --- ** [tickets:#7896] Better plaintext mail for commit notifications** **Status:** review **Milestone:** unreleased **Created:** Fri Jun 12, 2015 06:25 PM UTC by Dave Brondsema **Last Updated:** Thu Jul 06, 2017 05:55 PM UTC **Owner:** Dave Brondsema Our plaintext mail messages just send markdown without converting it to HTML. So all plain text views will see some markdown formatting. Commit notifications also include HTML tags in each commit message. This is from the `summary = g.markdown_commit.convert(ci.message)` in `def send_notifications` rendering commit-markdown -> HTML. (Before [#7825] the commit message text was just passed through without this step but that caused inadvertent markdown formatting for things like `__init__`, or `if (*pArray[j+1] > *pArray[j])` Example of the HTML coming through in plain text: https://forge-allura.apache.org/p/allura/pastebin/557b1ce16d19cd7007456025 I think a fix for this would have to include a way for commit notification logic to build the plain text version separately and pass that in to the mail functions. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. --===============1462717846432453919== MIME-Version: 1.0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit
  • status: open --> review
  • assigned_to: Dave Brondsema
  • Comment:

Fixed fairly well on db/8157

[tickets:#7896] Better plaintext mail for commit notifications

Status: review
Milestone: unreleased
Created: Fri Jun 12, 2015 06:25 PM UTC by Dave Brondsema
Last Updated: Thu Jul 06, 2017 05:55 PM UTC
Owner: Dave Brondsema

Our plaintext mail messages just send markdown without converting it to HTML. So all plain text views will see some markdown formatting. Commit notifications also include HTML tags in each commit message. This is from the summary = g.markdown_commit.convert(ci.message) in def send_notifications rendering commit-markdown -> HTML. (Before [#7825] the commit message text was just passed through without this step but that caused inadvertent markdown formatting for things like __init__, or if (*pArray[j+1] > *pArray[j])

Example of the HTML coming through in plain text: https://forge-allura.apache.org/p/allura/pastebin/557b1ce16d19cd7007456025

I think a fix for this would have to include a way for commit notification logic to build the plain text version separately and pass that in to the mail functions.

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

--===============1462717846432453919==-- --===============6646158616116468851==--