allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <d...@brondsema.net>
Subject [allura:tickets] #7994 Fix comments split across two threads, not all comments showing
Date Fri, 25 Sep 2015 18:45:36 GMT
- **status**: open --> review
- **assigned_to**: Dave Brondsema
- **Comment**:

db/7994

To test manually, easiest thing is to create 2 separate threads normally.  E.g. take 2 tickets
and post some comments on each, including attachments.  Then find one thread and change its
ref_id to point to the other ticket.

    // find the 2 threads.  e.g.:
    db.thread.find({app_config_id: from_url('/p/test/tickets')._id}
    // update one thread to use the same ticket as the other
    db.thread.update({_id: '31a14b04'}, {$set: {ref_id: 'forgetracker/model/ticket/Ticket#56056ff33a8da300156671d7'}})
    
Then you've got 2 threads with the same ticket.  On master if you visit the ticket page, you'll
only see one thread of comments.  On `db/7994` they'll get merged together for you.



---

** [tickets:#7994] Fix comments split across two threads, not all comments showing**

**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2 
**Created:** Mon Sep 21, 2015 09:32 PM UTC by Dave Brondsema
**Last Updated:** Mon Sep 21, 2015 09:32 PM UTC
**Owner:** Dave Brondsema


Google Code ticket imports can produce multiple "thread" objects with the same ref_id (pointer
to a ticket).  This means when viewing a ticket you get one of the comment threads, but you
wont see the other comment thread associated with it.

Back in [#4506] we wrote a script to fix this (was committed internal to SF at the time).
 We should move this script to Allura, or even better make the `get_discussion_thread` code
handle this situation and automatically clean it up.  No manually running scripts needed,
and not critical to fix the Google Code import logic then.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message