allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #7837 Use repo directly instead of DiffInfoDoc
Date Fri, 13 Mar 2015 19:22:26 GMT
- **status**: review --> in-progress
- **Comment**:

The new form of `paged_diffs` which uses `log` looks much better than the old logic in `refresh_commit_info`
which used `info2`.  However the `ClientError`s that the old implementation handled seem to
still be something we need to address.  I tried importing
since I knew it had those "non-existent in revision" errors.  It is a big repo (took few hours
to import and index); I'm sure you can find others that are smaller that exhibit it problem.
 If you run a refresh on master you can see the revisions it complains about.  Then on your
branch, go to the commit view for that revision + 1.  It will show no changed files, but it
should show some (compared to master).  It does seem to know how many changes there are, because
e.g. lists 3 pages (but no
items on those pages).

I dug into it a little bit and apparently `p['action'] == 'R'` so we need to figure out what
to do with that.  I'd also recommend adding this so any `ClientError` that might happen does
not get swallowed:

         except pysvn.ClientError:
+  'Error getting paged_diffs log of %s on %s', commit_id, self._url, exc_info=True)
             return result


** [tickets:#7837] Use repo directly instead of DiffInfoDoc**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-8 sf-current indexless 
**Created:** Fri Feb 20, 2015 10:40 PM UTC by Dave Brondsema
**Last Updated:** Thu Mar 12, 2015 03:50 PM UTC
**Owner:** Igor Bondarenko

See [#7828] for analysis of where DiffInfoDoc is used.  Goal is to remove it altogether, using
SCM data directly.  Then also remove the building of DiffInfoDoc records during repo refresh.
 (If there are really slow computations we could keep using DiffInfoDoc for a cache of those


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message