allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <d...@brondsema.net>
Subject [allura:tickets] #7833 Trim emails before saving them to mongo NEEDS SCRIPT
Date Thu, 19 Mar 2015 18:45:02 GMT
- **summary**: Trim emails before saving them to mongo --> Trim emails before saving them
to mongo NEEDS SCRIPT



---

** [tickets:#7833] Trim emails before saving them to mongo NEEDS SCRIPT**

**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current 
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Mar 19, 2015 06:42 PM UTC
**Owner:** Igor Bondarenko

Right now you can claim address like `"email@example.com   "` (note spaces in the end) or
even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from
some source. That's how I discovered this issue actually).

That's a problem because on the UI you can't see this blank symbols and later, when user types
the same email in, say, password recovery form, but without spaces in the end, system will
not find it, therefore user will not be able to recover password. Also, association of commits
with users and other stuff won't work.

Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use
it everywhere already, but it's good to test/investigate further.

Don't sure what to do with existing emails like this which are already in mongo.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message