allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <brond...@users.sf.net>
Subject [allura:tickets] #7527 Email address associations need better user associations
Date Mon, 18 Aug 2014 21:13:24 GMT
- **status**: code-review --> in-progress
- **Milestone**: forge-aug-8 --> forge-aug-22
- **Comment**:

Approach is looking good.  In the migration .js file you should have `$ne` instead of `$not`.
 Can you also split this into 3 files?  Something like this so that each file can be run on
its own cleanly:

* `030-email-address-_id-to-email--before-upgrade.js`
* `030-email-address-_id-to-email--after-upgrade.js`
* `030-email-address-_id-to-email--cleanup.js`

And then in the SF internal code, `M.EmailAddress.create` is creating too many records - a
new copy each time you log in.  Should just look up an existing record with the canonical
form of the email address I think.  Also need to ensure the email is marked as verified and
primary.



---

** [tickets:#7527] Email address associations need better user associations**

**Status:** in-progress
**Milestone:** forge-aug-22
**Created:** Wed Jul 02, 2014 09:08 PM UTC by Dave Brondsema
**Last Updated:** Tue Jul 29, 2014 10:02 PM UTC
**Owner:** Alexander Luberg

A user can claim any address and even if they don't verify it, that still blocks someone else
from trying to claim it.  This can be fixed in auth.py like:

~~~~
::diff
-                if M.EmailAddress.query.get(_id=new_addr['addr']):
+                if M.EmailAddress.query.get(_id=new_addr['addr'], confirmed=True):
~~~~

However this leads to another problem, if multiple users have the same email address claimed
(but not verified).  One user sees a "verify" link, but the other sees "Unknown addr obj foo@bar.com",
on the preferences page.

There probably are more issues when it gets to verification, too.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message