allura-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brondsema" <>
Subject [allura:tickets] #7472 Thread view counts shouldn't trigger add_artifact tasks
Date Mon, 25 Aug 2014 19:48:17 GMT
- **status**: code-review --> closed
- **QA**: Dave Brondsema
- **Milestone**: forge-backlog --> forge-sep-5


** [tickets:#7472] Thread view counts shouldn't trigger add_artifact tasks**

**Status:** closed
**Milestone:** forge-sep-5
**Labels:** performance 42cc 
**Created:** Tue Jun 17, 2014 03:25 PM UTC by Dave Brondsema
**Last Updated:** Thu Aug 21, 2014 01:32 PM UTC
**Owner:** Igor Bondarenko

The `ThreadController.index` method increases the  view count of the thread.  While it does
set `skip_mod_date`, it still makes the thread object "dirty" (in the ming odm session), and
thus ManagedSessionExtension/ArtifactSessionExtension thinks it is a change needing to be
saved into solr, so and `add_artifacts` task runs.  That is a lot of unnecessary work generated
from a pageview.  We shouldn't run the `add_artifacts` task (if not easy to avoid it, perhaps
easier to run a mongo `$inc` command and avoid the session).  And possibly consider not tracking
view counts at all.


Sent from because is subscribed to

To unsubscribe from further messages, a project admin can change settings at
 Or, if this is a mailing list, you can unsubscribe from the mailing list.
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message