allura-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jetm...@apache.org
Subject [24/50] [abbrv] allura git commit: [#7836] ticket:739 Use c.app in the merge_request_commits for git
Date Wed, 27 May 2015 11:57:56 GMT
[#7836] ticket:739 Use c.app in the merge_request_commits for git

It executes in the downstream context, so we need to use downstream app to
generate a list of commits. If we don't do that, we will see empty list on the
first request to the page (right after user creates merge request).


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/d98da988
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/d98da988
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/d98da988

Branch: refs/heads/ib/7868
Commit: d98da988f9f365ff80f43434076b37974936824e
Parents: d1310c6
Author: Igor Bondarenko <jetmind2@gmail.com>
Authored: Tue Apr 21 14:01:17 2015 +0000
Committer: Dave Brondsema <dbrondsema@slashdotmedia.com>
Committed: Wed May 20 19:43:17 2015 +0000

----------------------------------------------------------------------
 ForgeGit/forgegit/model/git_repo.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/d98da988/ForgeGit/forgegit/model/git_repo.py
----------------------------------------------------------------------
diff --git a/ForgeGit/forgegit/model/git_repo.py b/ForgeGit/forgegit/model/git_repo.py
index 99c5afe..aeb5734 100644
--- a/ForgeGit/forgegit/model/git_repo.py
+++ b/ForgeGit/forgegit/model/git_repo.py
@@ -643,7 +643,7 @@ class GitImplementation(M.RepositoryImplementation):
         Must be called within mr.push_downstream_context()
         """
         base = self.merge_base(mr)
-        return list(mr.app.repo.log(
+        return list(c.app.repo.log(
             mr.downstream.commit_id,
             exclude=base,
             id_only=False))


Mime
View raw message