allura-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brond...@apache.org
Subject [34/50] [abbrv] git commit: [#3905] Remove unused helper along with unportable test
Date Thu, 16 May 2013 22:30:25 GMT
[#3905] Remove unused helper along with unportable test

Signed-off-by: Peter Hartmann <peterhartmann@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/5983da70
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/5983da70
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/5983da70

Branch: refs/heads/db/6208
Commit: 5983da705ba5406372846f911e9012451068424b
Parents: bf43535
Author: Peter Hartmann <peterhartmann@apache.org>
Authored: Wed Apr 24 21:06:07 2013 +0200
Committer: Dave Brondsema <dbrondsema@slashdotmedia.com>
Committed: Tue May 14 18:58:54 2013 +0000

----------------------------------------------------------------------
 Allura/allura/lib/helpers.py        |    7 -------
 Allura/allura/tests/test_helpers.py |    3 ---
 2 files changed, 0 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/5983da70/Allura/allura/lib/helpers.py
----------------------------------------------------------------------
diff --git a/Allura/allura/lib/helpers.py b/Allura/allura/lib/helpers.py
index c7b8fc6..5ac7abb 100644
--- a/Allura/allura/lib/helpers.py
+++ b/Allura/allura/lib/helpers.py
@@ -155,13 +155,6 @@ def find_project(url_path):
         length -= 1
     return None, url_path.split('/')
 
-def find_executable(exe_name):
-    '''Find the abspath of a given executable (which
-    must be on the PATH)'''
-    for dirname in os.environ['PATH'].split(os.pathsep):
-        path = os.path.join(dirname, exe_name)
-        if os.access(path, os.X_OK): return path
-
 def make_neighborhoods(ids):
     return _make_xs('Neighborhood', ids)
 

http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/5983da70/Allura/allura/tests/test_helpers.py
----------------------------------------------------------------------
diff --git a/Allura/allura/tests/test_helpers.py b/Allura/allura/tests/test_helpers.py
index 6eb1719..3ed21f4 100644
--- a/Allura/allura/tests/test_helpers.py
+++ b/Allura/allura/tests/test_helpers.py
@@ -90,9 +90,6 @@ def test_find_project():
     proj, rest = h.find_project('/p/testable/foo')
     assert proj is None
 
-def test_find_executable():
-    assert h.find_executable('bash') == '/bin/bash'
-
 def test_make_users():
     r = h.make_users([None]).next()
     assert r.username == '*anonymous', r


Mime
View raw message