From dev-return-8733-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Jun 24 08:05:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3329A180671 for ; Mon, 24 Jun 2019 10:05:36 +0200 (CEST) Received: (qmail 15425 invoked by uid 500); 24 Jun 2019 08:05:34 -0000 Mailing-List: contact dev-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list dev@airflow.apache.org Received: (qmail 15412 invoked by uid 99); 24 Jun 2019 08:05:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jun 2019 08:05:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A8BEBC2C76 for ; Mon, 24 Jun 2019 08:05:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.811 X-Spam-Level: * X-Spam-Status: No, score=1.811 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=polidea.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id hZBfPKAbK2tc for ; Mon, 24 Jun 2019 08:05:32 +0000 (UTC) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BB4705F366 for ; Mon, 24 Jun 2019 08:05:31 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id e3so436429ioc.12 for ; Mon, 24 Jun 2019 01:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polidea.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qlh7spKcnOphuWpJopFrhITsAR/OqCgtXiyaNapBMqA=; b=K6AlRun4Pe9yfsC373Z5DKHQxCE1GKAwkahNSyZVInd0s70EpRZi5B9IT/UeUKo4qN McXPyxrnwmDIqjkeX54d3UO0aHNrFNXmDunC9OnuwxhBy4xQkzyAh+tTVME6TJVSLsGO WEFnPRp2rKYgE6Aon6t+PYm7fdM+mHLJKStKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qlh7spKcnOphuWpJopFrhITsAR/OqCgtXiyaNapBMqA=; b=EUkhoAdGc/i963kQxJYOJjDHmsOXIvhf2+x8ryWIQhLxL/hJo4XgZTP376H/5VmhKG Zf7Vy/mNOZPdvk+lc6wja3TZKfajGnrpuvBGLZdVDlExQU7UcDfZw0Afkp8kTehAyudk Bnrh+PWtrPKXWp4w5YGhmMUmH/U+kAb1KGuofeIKvqp5zFt+1ConMhTX/LwtcJpeH3BB vHZOaY7k7ACjPF1AFgx2bHUrLoxaEBGRGQIjINny3hapusNNvVVFb80Uoyk3/22Ifjkz K5fGpLI/7g7PPxuexrr2HOfWCoEDEla/8MWa4Y4oq8f7F+kf+OLBgUN+kiIfKhU16rL3 UtDw== X-Gm-Message-State: APjAAAWloBbXtmg4fzjki7c+vOkyJ/Y2VTaWjAZ2EG2tFasr0uybe0Ky GgM8Hn++ccvLbxIDKb+Xv8F2Evk9yKcF/XYpIv+csQ== X-Google-Smtp-Source: APXvYqxeuT5lMxpuSJycMPUxaS/N/95+m+Ojc7mtV83xhbaNgN2XOCNqdqnzEbbDTy8vu3lP96SPDHzHaQmBv7DThcE= X-Received: by 2002:a5d:8f99:: with SMTP id l25mr2587939iol.92.1561363524767; Mon, 24 Jun 2019 01:05:24 -0700 (PDT) MIME-Version: 1.0 References: <3E86E9E6-E9BD-4BA1-8EC3-F4F5D0591E40@apache.org> In-Reply-To: From: Jarek Potiuk Date: Mon, 24 Jun 2019 10:05:12 +0200 Message-ID: Subject: Re: Latest Sphinx (2.1.2) causes master to fail To: Ash Berlin-Taylor Cc: dev@airflow.apache.org, =?UTF-8?Q?Kamil_Bregu=C5=82a?= , Fokko Driesprong Content-Type: multipart/alternative; boundary="000000000000426ad2058c0d46a6" --000000000000426ad2058c0d46a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK. After some checks it turns out it's not only Sphinx really but also sphinx-autoapi (v 1.1.0 released yesterday). J. On Mon, Jun 24, 2019 at 9:29 AM Jarek Potiuk wrote: > Kamil prepared a fix https://github.com/apache/airflow/pull/5468 (thanks!= ) and > when I tested it on a clean pip-install with latest sphinx it seems to wo= rk > fine (Running Travis CI build > now). Let's see if > it helps. > > BTW. The AIP-10 Docker image last step (pending Kubernetes fix) should > solve most of the dependency issues, however I think this particular > problem could be missed (it's an interesting one). > > I will soon start another thread (after dockerfile merging) about finally > looking into making dependencies more manageable and less transient-deps > problems. I already have some ideas how we can approach the problem that > Airflow is both: library (no-dependency pinning recommended) and > end-product (strong pinning recommended). > > J. > > On Mon, Jun 24, 2019 at 8:48 AM Ash Berlin-Taylor wrote: > >> Any cyclic imports we have aren't actually a problem and are handled fin= e >> by python 3 (obviously, else it wouldn't work) so I think this is a big = in >> sphinx with it being over zealous. >> >> This only affects tests and development, not our users in this case. >> >> If it's difficult to fix I would go with pinning - I want to get a 1.10.= 4 >> beta 1 out today. >> >> -ash >> >> On 24 June 2019 00:37:57 BST, Jarek Potiuk >> wrote: >>> >>> Hello Everyone, >>> >>> We have yet another case where relesing a package (Sphinx 2.1.2 in this >>> case) - started to cause master to fail. >>> >>> Should we pin Sphinx to an earlier version or maybe someone can help a= nd >>> figure out and fix it quickly (seems that there are some cyclic imports >>> that probably need solving anyway if Sphinx is right about them) ? @Kam= il >>> Bregu=C5=82a @Fokko Driesprong >>> ? WDYT ? >>> >>> I created an issue for that >>> https://issues.apache.org/jira/browse/AIRFLOW-4841 >>> >>> J. >>> >>> > > -- > > Jarek Potiuk > Polidea | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > [image: Polidea] > > --=20 Jarek Potiuk Polidea | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] --000000000000426ad2058c0d46a6--