From dev-return-8696-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Wed Jun 19 02:02:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B48EA18066B for ; Wed, 19 Jun 2019 04:02:41 +0200 (CEST) Received: (qmail 75620 invoked by uid 500); 19 Jun 2019 02:02:39 -0000 Mailing-List: contact dev-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list dev@airflow.apache.org Received: (qmail 75608 invoked by uid 99); 19 Jun 2019 02:02:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2019 02:02:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 84EE6C0834 for ; Wed, 19 Jun 2019 02:02:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.052 X-Spam-Level: *** X-Spam-Status: No, score=3.052 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, HTML_MESSAGE=2, KAM_SHORT=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xCme8s53YoD0 for ; Wed, 19 Jun 2019 02:02:36 +0000 (UTC) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A16375F533 for ; Wed, 19 Jun 2019 02:02:36 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id x187so6911927ybc.11 for ; Tue, 18 Jun 2019 19:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=sGpjesW5vv9pt2nvri/qPic3uv5/sFBfVX3qIziNrBo=; b=jLxmDyHVmnf2s0W6k/z0Exs2EAR+OmtzGknjJrfeX13DUiLzgvQtgKGh7rKD+SFqx1 VJoFosUGuUDOduJuwPCD+ECNBLMwOu6OVCTdNoEd+v/yN1NfFCMesuYg0H455JIeyX7q xMpW21m5nIw1M0PP5mgDqGfj/CaXHMRBrAhoS5mFU1CUXXs47GXO3DvwbbgclnkxrvwZ rZJGPkLLmpa10O7zT56SJlye7HlqNLcYbMBQxRO2YjW4P8bu2wUu4wPjAdNhxjMNL1S1 RRIn5rXeZlgccbobIW2vy9BgHUeK/OOf16VHG7y5xIG7027+CT1SZbdebLLKYdYFkQwD m3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=sGpjesW5vv9pt2nvri/qPic3uv5/sFBfVX3qIziNrBo=; b=fHX1wngSk5Muf9oJlKQZlAFwUwRPxNWBqc9jkPa7VUWvYbKtAzyILxYitVqe22A6TP PfD1pmaLnlqrxYn1vlxCGsy7kB5YvdjiaBUGB89YurGa5ygX8sIUaWrpgt7D+84aQBIy JcRWtQ8u8HQGSxd5m1L61LXyLavMyeLLtKTEeWUYpJHN+lIcXNQDlew4/VvhNd34pP6w 4kiZE8g/h6rYj26MBXONx4urjvspDirHE8biKVCjGRBD1ew7xlLuGj3dkwLqSVTNe+8L 9yIi5xQDwq+LTsBVzIR70zch8Y9jmlgH0Ex2Vb3Cfjs86dfzWr4mQ8zqnsJoxXZ/dUJr dXag== X-Gm-Message-State: APjAAAWs2ljNjXn+m9VJxTw5adbz3XYemvIXzUa1V0VSS5Lhh+KYf/zr x/CgOnNTRUSyq1rrh/OBYrrND7etWyYRypyp8SjcqpML X-Google-Smtp-Source: APXvYqzlbonUB6eHIGP0q760qkeLQdUjl/bC5dXaxJ/QGBFIo0kxF25InDmdhNUuHxg9zvqhepffkNov+E3xZay7HcA= X-Received: by 2002:a25:3851:: with SMTP id f78mr65932281yba.236.1560909755695; Tue, 18 Jun 2019 19:02:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chao-Han Tsai Date: Tue, 18 Jun 2019 19:02:24 -0700 Message-ID: Subject: Re: [DISCUSS] Pull Request Improvements To: dev@airflow.apache.org Content-Type: multipart/alternative; boundary="00000000000083c80c058ba39f17" --00000000000083c80c058ba39f17 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +1 Watched the pull panda video and I think the offering is great and beneficial to Airflow. Chao-Han On Tue, Jun 18, 2019 at 8:24 AM Ry Walker wrote: > +1 we use pull-reminders at Astronomer, good experience. Airflow might be > a bit rough at first with 193 pending PRs, but it will help get that # do= wn > :) > > Sent via Superhuman iOS ( https://sprh.mn/?vip=3Dry@rywalker.com ) > > On Tue, Jun 18 2019 at 7:31 AM, < fokko@driesprong.frl > wrote: > > > > > > > > > It looks great, and I think it Airflow would benefit from it. I would s= ay > > go for it, and open up an infra ticket to get it set up :-) > > > > > > > > Cheers, Fokko > > > > > > > > Op di 18 jun. 2019 om 13:27 schreef Jiajie Zhong > > > >: > > > > > >> > >> > >> I watch the pull-panda video and think it is great! I think maybe we > could > >> have a try on it. > >> > >> > > > > > > > > > > > > > > > > > >> > >> > >> Best Wish > >> =E2=80=94 Jiajie > >> > >> > > > > > > > > > > > > > > > > > > > > >> > >> > >> On Jun 18, 2019, at 17:45, Jarek Potiuk >> Jarek.Potiuk@polidea.com>> wrote: > >> > >> > > > > > > > > > > > > > > >> > >> > >> Just started this morning to test Pull Panda on our internal repo. Loo= ks > >> like really useful - it's slack integration is really nice. All for it= ! > >> > >> > > > > > > > > > > > > > > >> > >> > >> J. > >> > >> > > > > > > > > > > > > > > > > > >> > >> > >> On Tue, Jun 18, 2019 at 11:44 AM Felix Uellendall > >> > > >> wrote: > >> > >> > > > > > > > > > > > > > > >> > >> > >> Hey all, > >> > >> > > > > > > > > > > > > > > >> > >> > >> Pull request are currently often forgotten after they moved to the > second > >> page and I think this is really frustrating for pr's authors to wait s= o > >> long for their pr's getting merged and we can and should do more about > it. > >> Our number of committers is growing, but I think we can also improve t= he > >> process of handling Pull Request and their reviews. > >> > >> > > > > > > > > > > > > > > >> > >> > >> So I just noticed that GitHub acquired Pull Panda: > >> https://github.blog/2019-06-17-github-acquires-pull-panda/ > >> > >> > > > > > > > > > > > > > > >> > >> > >> It would help us to remind pr's ready for being reviewed, balance the > >> workload for committers to review them and overall being able to get > Pr's > >> more quickly merged and released. > >> > >> > > > > > > > > > > > > > > >> > >> > >> I think this would be a huge benefit for us all. What do you think? > >> > >> > > > > > > > > > > > > > > >> > >> > >> Kind regards, > >> feluelle > >> > >> > > > > > > > > > > > > > > >> > >> > >> Sent from ProtonMail mobile > >> > >> > > > > > > > > > > > > > > > > > > > > >> > >> > >> -- > >> > >> > > > > > > > > > > > > > > >> > >> > >> Jarek Potiuk > >> Polidea | Principal Software Engineer > >> > >> > > > > > > > > > > > > > > >> > >> > >> M: +48 660 796 129 <+48660796129> > >> [image: Polidea] > >> > >> > > > > > > > > > > > > > > > > > > --=20 Chao-Han Tsai --00000000000083c80c058ba39f17--