From dev-return-8201-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Apr 15 19:29:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF8D618064C for ; Mon, 15 Apr 2019 21:29:31 +0200 (CEST) Received: (qmail 74461 invoked by uid 500); 15 Apr 2019 19:29:30 -0000 Mailing-List: contact dev-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list dev@airflow.apache.org Received: (qmail 74387 invoked by uid 99); 15 Apr 2019 19:29:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Apr 2019 19:29:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EEE0FC1DA8 for ; Mon, 15 Apr 2019 19:29:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OIp1YlzUMkKG for ; Mon, 15 Apr 2019 19:29:08 +0000 (UTC) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D97E05F5EF for ; Mon, 15 Apr 2019 19:21:14 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id v13so16785276ljk.4 for ; Mon, 15 Apr 2019 12:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=8MPQ9z43lRcEH8AlfBVQnYVsiiozfG6YnCEQZ+0+VYQ=; b=AiYhyO9hfCvpNjDpzsONFPJpAKx1HTSALYfdzHWgD6HtEESVRfOy4Bi93YSA6JemlN Boe61TMCvtsDzeuMkqVSn1SjGKfAoiVRisi4ZQypu9OTM1mH5ia4lerCa+d4g0dEwbzg UdFuRQgq5LshZUMryd0twXs77HaSd6t6WWCXbXn8/FfUDulooYmXOFlPCVXVgQysnCOx S5CEUlnxr9IFgdmaxaVHaCHN6+gqP6ohC3wM9kRWLyWz+X/++HBnkwHPdfwB2U/wEUzO mNgXI9dLTCeb9xtZL0LUxGOcM9qBjSAOtGsRLWET0B0ek2+ZsIpjSM0SgeH9Re2BclRi I/bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=8MPQ9z43lRcEH8AlfBVQnYVsiiozfG6YnCEQZ+0+VYQ=; b=V+yzQUQ6dWeBDMlRQEZfrfJk0uFW2pMkubq/2CSjZdtdAOGnqe0Q0MqQljAJcRVULo CeKBqxFncjegK04RIUO3RwKR4eQNSy6Xf2FTil1yymYgZWLKhKIc30+sq+I92ghBIbUz RPApAG2EvlOmXMlsFlsARXxuIfGadtQtlzxpD7HOpHcZG7FjZFyUgDKZT2JVb9IqHqe9 ltOyqDkB6GjibDlBbrN2YsyJ3KNnXMsYoKgIjfyfeggnbxoj/04FiXIj2f88HmO1mcUA xLbxZxAa2hr7NJP40LidhNa2/7oHie5WaK8/jt9LEgNhoKbt5+JxzdGEv6TvnZTgi83n GJUw== X-Gm-Message-State: APjAAAUJcegQdOFvTVsqqkIXvsAxDW2/sGmc56JlZbVX9spXLULMtI81 Gk91Lj57lH7PW19Kz8J4ce74JQv+Q/Q9Nm9uzyU3Zg== X-Google-Smtp-Source: APXvYqx5XcEHtMsB9ER15r6/r+UKNZo08qBS5gYCDyuSuUvuPkpTF9XnIoXRGxNZJF6t/vceA8Iec1W2LAkRlszNTgY= X-Received: by 2002:a2e:8ece:: with SMTP id e14mr24492231ljl.66.1555356073542; Mon, 15 Apr 2019 12:21:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Maxime Beauchemin Date: Mon, 15 Apr 2019 12:21:02 -0700 Message-ID: Subject: Re: [VOTE] AIP-6 Apply Pylint to Airflow To: dev@airflow.apache.org Content-Type: multipart/alternative; boundary="000000000000434b310586968e46" --000000000000434b310586968e46 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable pylint and black are super solid, no questions there afaic Max On Mon, Apr 15, 2019 at 11:48 AM m@maximilianroos.com wrote: > Hi there, > > I haven't been active in the airflow community so this should be weighed > appropriately. > > I'm a core dev of a couple of other libraries (xarray, pandas-gbq) and > have led initiatives to clean up the code in both of those. > > While I'm very enthusiastic about auto-formatting tools, my experience is > that finding settings that aren't overly strict but still contribute is > extremely difficult. Have people worked on large projects with pylint? > > I thought the recent thread around improving the contribution process was > insightful. Auto-enforcing coding standards can be v helpful for both new > contributors and reviewers, but a bad tool makes that harder, particularl= y > for new contributors who aren't used to them. > > Ofc, if someone knows of large projects that successfully use pylint, I'd > appreciate learning that my view of the tool is wrong! > > Thanks for everyone's hard work, > Max > > On 2019/04/11 20:50:01, Bas Harenslak > wrote: > > Hello Airflow community, > > > > This email calls for a vote to introduce Pylint in the Airflow project. > The vote will last for at least 1 week (April 18th 23:00 CET), and at lea= st > three +1 (binding) votes have been cast. > > > > After feedback on AIP-6 and discussion on Slack< > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I > propose to vote for adding Pylint to the Airflow > project for static code checking. Pylint complements Flake8 with stricter > rules, detects code smells and is customisable so unnecessary checks can = be > ignored. This should benefit the Airflow code base with consistent, > documented code and less errors. > > > > Note that Pylint 2.0 works with Python 3 only, so if the vote is > successful, it should be introduced after dropping support for Python 2 > (AIRFLOW-4196). > > Note2: to keep the scope as small as possible, I=E2=80=99ll create a se= parate > vote for Black formatting. > > > > Cheers, > > Bas > > > --000000000000434b310586968e46--