airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxime Beauchemin <maximebeauche...@gmail.com>
Subject Re: [VOTE] AIP-6 Apply Pylint to Airflow
Date Fri, 12 Apr 2019 05:25:08 GMT
+1 (binding)

Also check out black to auto-pep8!
https://github.com/ambv/black

On Thu, Apr 11, 2019 at 5:12 PM Tao Feng <fengtao04@gmail.com> wrote:

> +1
>
> On Thu, Apr 11, 2019 at 4:27 PM Beau Barker <beauinmelbourne@gmail.com>
> wrote:
>
> > +1 non binding
> >
> > Pylint is extremely strict so your may want to be selective about the
> > rules it applies.
> >
> >
> > > On 12 Apr 2019, at 7:15 am, Kamil Breguła <kamil.bregula@polidea.com>
> > wrote:
> > >
> > > +! (non-binding)
> > >
> > > On Thu, Apr 11, 2019 at 11:05 PM Driesprong, Fokko
> <fokko@driesprong.frl
> > >
> > > wrote:
> > >
> > >> +1 (binding)
> > >>
> > >> For more information about AIP-6:
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=99844429
> > >>
> > >> Op do 11 apr. 2019 om 23:03 schreef Kaxil Naik <kaxilnaik@gmail.com>:
> > >>
> > >>> +1 (binding)
> > >>>
> > >>> On Thu, Apr 11, 2019 at 9:51 PM Jarek Potiuk <
> Jarek.Potiuk@polidea.com
> > >
> > >>> wrote:
> > >>>
> > >>>> +1 (non-binding).
> > >>>>
> > >>>> On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak <
> > >>>> basharenslak@godatadriven.com> wrote:
> > >>>>
> > >>>>> Hello Airflow community,
> > >>>>>
> > >>>>> This email calls for a vote to introduce Pylint in the Airflow
> > >> project.
> > >>>>> The vote will last for at least 1 week (April 18th 23:00 CET),
and
> at
> > >>>> least
> > >>>>> three +1 (binding) votes have been cast.
> > >>>>>
> > >>>>> After feedback on AIP-6 and discussion on Slack<
> > >>>>>
> > >> https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400
> > >>>> ,
> > >>>> I
> > >>>>> propose to vote for adding Pylint<https://pylint.org>
to the
> Airflow
> > >>>>> project for static code checking. Pylint complements Flake8
with
> > >>> stricter
> > >>>>> rules, detects code smells and is customisable so unnecessary
> checks
> > >>> can
> > >>>> be
> > >>>>> ignored. This should benefit the Airflow code base with consistent,
> > >>>>> documented code and less errors.
> > >>>>>
> > >>>>> Note that Pylint 2.0 works with Python 3 only, so if the vote
is
> > >>>>> successful, it should be introduced after dropping support
for
> > >> Python 2
> > >>>>> (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196
> >).
> > >>>>> Note2: to keep the scope as small as possible, I’ll create
a
> separate
> > >>>> vote
> > >>>>> for Black formatting.
> > >>>>>
> > >>>>> Cheers,
> > >>>>> Bas
> > >>>>>
> > >>>>
> > >>>>
> > >>>> --
> > >>>>
> > >>>> Jarek Potiuk
> > >>>> Polidea <https://www.polidea.com/> | Principal Software Engineer
> > >>>>
> > >>>> M: +48 660 796 129 <+48660796129>
> > >>>> E: jarek.potiuk@polidea.com
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> *Kaxil Naik*
> > >>> *Big Data Consultant *@ *Data Reply UK*
> > >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark &
> > Neo4j
> > >>> Developer
> > >>> *LinkedIn*: https://www.linkedin.com/in/kaxil
> > >>>
> > >>
> > >
> > >
> > > --
> > >
> > > Kamil Breguła
> > > Polidea <https://www.polidea.com/> | Software Engineer
> > >
> > > M: +48 505 458 451 <+48505458451>
> > > E: kamil.bregula@polidea.com
> > > [image: Polidea] <https://www.polidea.com/>
> > >
> > > We create human & business stories through technology.
> > > Check out our projects! <https://www.polidea.com/our-work>
> > > [image: Github] <https://github.com/Polidea> [image: Facebook]
> > > <https://www.facebook.com/Polidea.Software> [image: Twitter]
> > > <https://twitter.com/polidea> [image: Linkedin]
> > > <https://www.linkedin.com/company/polidea> [image: Instagram]
> > > <https://instagram.com/polidea> [image: Behance]
> > > <https://www.behance.net/polidea>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message