From dev-return-7313-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Jan 7 08:37:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E2E3180647 for ; Mon, 7 Jan 2019 08:37:56 +0100 (CET) Received: (qmail 86243 invoked by uid 500); 7 Jan 2019 07:37:55 -0000 Mailing-List: contact dev-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list dev@airflow.apache.org Received: (qmail 86226 invoked by uid 99); 7 Jan 2019 07:37:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2019 07:37:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 17789C700A for ; Mon, 7 Jan 2019 07:37:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=soundcloud.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id k5LJjKWMNZSV for ; Mon, 7 Jan 2019 07:37:52 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CE68160FBD for ; Mon, 7 Jan 2019 07:37:51 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id y20so36927192edw.9 for ; Sun, 06 Jan 2019 23:37:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+41jdY7NHNmziNocDcRmoZ5/8oPHilj3MoKFcjRLW/I=; b=KQKRSsnfFz/zrbgA5vBvhQ5AmtJU+3FowER1ahTh8qxicY5QOJcVfGbfwijqY+HLpD ZI+5cXQwZlRecxOfW4aoXRk81R2v1Mg8w/IRr8yIr34PemHaRrYX/juam8NOEwrLx606 hsYc++ff2kwo85AnhGkkvXs4+US/GreZ03d1OXRKuR6+5JloO6c0RRL+036l0+tDk0f+ Jkw2aF+DigDWD0hTkuyIHgtXVBIKgbgpKTBoB9vP0BVElt1JPMaxnMhjs37m/tBOFse4 jC0YW7mgwvRHZpuC2/OwnY9zyzpntMpsJs9AAVkbDzPaDCnWwjyP5dkxvWFA2xK0SpPK SDKQ== X-Gm-Message-State: AA+aEWa2dV2hjpwAbhZa/AvNyHP5dX6sqOS1q2Ils/9PMlOFIsxBWoga /FLI97yOPg5+W4qonrGm41SfiOv2qpi84g== X-Google-Smtp-Source: AFSGD/UK9Mmba8+Wu/V+lrJ7ZVFR6H7QJmi7+OpWE+fSi/8KZ34VMUdoU1y8B5Bt+q5GmLLHoKBVNw== X-Received: by 2002:a17:906:f14e:: with SMTP id gw14-v6mr46376118ejb.231.1546846665034; Sun, 06 Jan 2019 23:37:45 -0800 (PST) Received: from [10.10.13.3] ([80.82.202.196]) by smtp.gmail.com with ESMTPSA id e35sm29911699eda.13.2019.01.06.23.37.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jan 2019 23:37:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: Travis CI reporting incorrectly From: =?utf-8?Q?Bj=C3=B6rn_Pollex?= In-Reply-To: Date: Mon, 7 Jan 2019 08:37:40 +0100 Cc: Deng Xiaodong , "Driesprong, Fokko" Content-Transfer-Encoding: quoted-printable Message-Id: <989DA0FB-C741-4DB7-8BE9-5E7DAB31F9A2@soundcloud.com> References: <67A68079-D3D8-4162-8E14-D017399DCB20@gmail.com> <143BAA4C-BA2B-4AF1-BBE4-60EBE162C721@gmail.com> To: dev@airflow.apache.org X-Mailer: Apple Mail (2.3445.102.3) Hijacking this thread for a related problem. A couple of weeks ago I = posted to the mailing list that some of the tests for the plugins = manager are failing when I run them locally. Now, looking at the CI = output linked above, it seems none of these tests is even run in CI. I = have no experience with nose for running tests, could it be because the = filename doesn=E2=80=99t start with test_? Is this intentional? Cheers, Bj=C3=B6rn > On 6. Jan 2019, at 10:39, Tao Feng wrote: >=20 > I commit three fixes to the master branch with CI( > = https://travis-ci.org/apache/airflow/builds/475904686?utm_source=3Dgithub_= status&utm_medium=3Dnotification). > Most of the ORMs pass except the mysql one which fails at > = https://github.com/apache/airflow/blob/master/tests/www_rbac/test_views.py= #L1465 > introduced in https://github.com/apache/airflow/pull/4407. >=20 > Not sure if it is a flaky test or a real issue. >=20 > On Sat, Jan 5, 2019 at 9:16 PM Tao Feng wrote: >=20 >> I will submit a pr to fix the test for PR # 4432 . >>=20 >>=20 >>=20 >> On Sat, Jan 5, 2019 at 7:45 PM Deng Xiaodong = wrote: >>=20 >>> Thanks Kaxil for fixing this. >>>=20 >>> Obvious that some errors were introduced into Master branch in the = last >>> few days during which the Travis CI was not working as expected. >>>=20 >>> - Some of the fails were due to a logic error in `delete_dag`, which = was >>> introduced into master branch in PR #4406 six days ago ( >>> https://github.com/apache/airflow/pull/4406, `[AIRFLOW-3599] Removed >>> DagBag from delete dag`). >>>=20 >>> I already prepared a PR to fix it ( >>> https://github.com/apache/airflow/pull/4445 , [AIRFLOW-3635] Fix >>> incorrect logic in delete_dag). This fix reduces fails & errors from = =E2=80=9C8 >>> FAILED, 2 errors=E2=80=9D to =E2=80=9C3 FAILED, 1 error=E2=80=9D. = Please review. >>>=20 >>> - Other fails & errors are due to multiple reasons. One of them is = that >>> test was not updated for PR # 4432 ([AIRFLOW-3622] Add ability to = pass >>> hive_conf to HiveToMysqlTransfer >>> = ). >>> May anyone pick this up? >>>=20 >>> Thanks. >>>=20 >>>=20 >>> XD >>>=20 >>> On 5 Jan 2019, at 11:52 PM, Kaxil Naik wrote: >>>=20 >>> It is fixed now. I will merge that PR ( >>> https://github.com/apache/airflow/pull/4441) once the CI build = finishes. >>>=20 >>> It is now reporting error correctly. Can someone approve the PR? >>>=20 >>>=20 >>>=20 >>> On Sat, Jan 5, 2019 at 3:38 PM Naik Kaxil wrote: >>>=20 >>> I have that in my PR but it still failed. I made another change and >>> triggered the CI, let's see >>>=20 >>>=20 >>> Kaxil Naik >>>=20 >>> Data Reply >>> Nova South >>> 160 Victoria Street, Westminster >>> London SW1E 5LB - UK >>> phone: +44 (0)20 7730 6000 >>> k.naik@reply.com >>> www.reply.com >>>=20 >>> [image: Data Reply] >>> ------------------------------ >>> *From:* Deng Xiaodong >>> *Sent:* Saturday, January 5, 2019 3:20:57 PM >>> *To:* dev@airflow.apache.org >>> *Cc:* Tao Feng; Driesprong, Fokko >>> *Subject:* Re: Travis CI reporting incorrectly >>>=20 >>> Hi Kaxil, >>>=20 >>> Not sure if you guys have found the root-cause. If not, I suspect = it=E2=80=99s >>> because of this line =E2=80=9Csudo ln -s ${ROOTDIR} >>> /home/travis/build/apache/incubator-airflow=E2=80=9D in >>>=20 >>> = https://github.com/apache/airflow/blob/master/scripts/ci/5-run-tests.sh#L9= 7 >>> = >>> . >>> It was not updated accordingly in PR 4419. >>>=20 >>> Please check. >>>=20 >>> Thanks. >>>=20 >>>=20 >>> XD >>>=20 >>> On 5 Jan 2019, at 11:06 PM, Kaxil Naik wrote: >>>=20 >>> An Example is the latest build: >>> https://travis-ci.org/apache/airflow/jobs/475704671#L7363 >>>=20 >>> It had "8 FAILED, 2 errors, 40 skipped (2072 tests passed)" >>>=20 >>> But still the test show as successful. >>>=20 >>> On Sat, Jan 5, 2019 at 1:18 PM Kaxil Naik = wrote: >>>=20 >>> Sorry - I meant I think it *is* because of the renaming of the repo. >>>=20 >>> On Sat, Jan 5, 2019 at 1:14 PM Kaxil Naik = wrote: >>>=20 >>> Hi guys, >>>=20 >>> Travis CI is reporting the build status incorrectly. Few of the = tests >>> have failed but it still shows the overall test as passed. >>>=20 >>> Request to all the committers to not merge any PR before going to >>>=20 >>> Travis >>>=20 >>> and checking. >>>=20 >>> PS: I don't think it has anything to do with renaming for >>> incubator-airflow to airflow >>>=20 >>> Regards, >>>=20 >>> *Kaxil Naik* >>>=20 >>>=20 >>>=20 >>> -- >>> *Kaxil Naik* >>> *Big Data Consultant *@ *Data Reply UK* >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & >>>=20 >>> Neo4j >>>=20 >>> Developer >>> *Phone: *+44 (0) 74820 88992 >>> *LinkedIn*: https://www.linkedin.com/in/kaxil >>>=20 >>>=20 >>>=20 >>> -- >>> *Kaxil Naik* >>> *Big Data Consultant *@ *Data Reply UK* >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & = Neo4j >>> Developer >>> *Phone: *+44 (0) 74820 88992 >>> *LinkedIn*: https://www.linkedin.com/in/kaxil >>>=20 >>>=20 >>>=20 >>>=20 >>> -- >>> *Kaxil Naik* >>> *Big Data Consultant *@ *Data Reply UK* >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & = Neo4j >>> Developer >>> *Phone: *+44 (0) 74820 88992 >>> *LinkedIn*: https://www.linkedin.com/in/kaxil >>>=20 >>>=20 >>>=20