From dev-return-7310-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Jan 6 04:46:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9C84180645 for ; Sun, 6 Jan 2019 04:46:03 +0100 (CET) Received: (qmail 21508 invoked by uid 500); 6 Jan 2019 03:46:02 -0000 Mailing-List: contact dev-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list dev@airflow.apache.org Received: (qmail 21480 invoked by uid 99); 6 Jan 2019 03:46:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Jan 2019 03:46:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D6D7180E7E for ; Sun, 6 Jan 2019 03:46:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 55_Zgvocf4EN for ; Sun, 6 Jan 2019 03:45:58 +0000 (UTC) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 147715FB33 for ; Sun, 6 Jan 2019 03:45:58 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id i12so20162429pfo.7 for ; Sat, 05 Jan 2019 19:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=LjrGay6CTLCs0bZIbQYBLw/NSjuOjHkZUw8/z8Kdl5A=; b=qi5/RF4Bx/BnP3IV2TyW7mO3Q65yB+SnuYZcDN+/DhoBFStNHMbQ84VI/a0gPTORYF YSnxG6keeyCU+ls6GB8h9t1Fg3xgRR6dWZSPXZxPSl81LMzd6NhpXzPC3fpr32FBfXBc /z1ktzd+hI9CTPkrEQPJZp/VGOab6Cdil0CTnagYCRYtVkqN+jbixx1QcTBd3oY09+IV souXVZ8xgJrbjxC4sDqOtqIOsK73so7QKLdh6GXvA3oi3c6G9+3YfmjBzp22bw8mh2HN qzDwmWaRFDzDW/mzH6dQbwHW5HMYkbj+zS2P8WhCEpSdBTPbO/Z92E3ZdQk+41LcZ8yx GJ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=LjrGay6CTLCs0bZIbQYBLw/NSjuOjHkZUw8/z8Kdl5A=; b=K51L31WpzqwDKkI1C3bxFYyXZ6pTk0dmwmHNUUD8+UIq+dPo9rTMQ3V1tpNqVTGKQt wktzckScQLVOkFyc7QrZG789mVyFKoxiqOJG5jfLO31y24qlcheDCfzepSsmmyRWtDal 4cKYmePlJt0V9+25inTN+ASUQZu7mQ3geWbi9mDZm9bL280wp72SxnKcJnWhxzuTFVC1 EEj5AS28fUDfxVwbyj3LV0joMgbwL4BKY+2vWmzkRtrwMtdxRKKLIQFCoTpshICYpkL7 QkbWpL1cJdNiB+tzmfmOu7a494sV1kSzROJa0LZNHkmNVEAxWjZZMYAvHgtYVE1ZzU0y 6N4Q== X-Gm-Message-State: AA+aEWYfC66C457M8tMOviFo5whU1LJOo04wUKKZKum3u//aIVRAhoK1 eG6bhCILkxftKcXkHQPxqwJhMJ0O0OU= X-Google-Smtp-Source: AFSGD/Vh9N7Spn7Qe1pC4crZv9Knfb5h207bjfO8NuwVVsU4KKTnZUjg8aEH207VXfSd6sPzn9ICSA== X-Received: by 2002:a62:d701:: with SMTP id b1mr57099599pfh.34.1546746356852; Sat, 05 Jan 2019 19:45:56 -0800 (PST) Received: from [192.168.1.78] (bb119-74-126-50.singnet.com.sg. [119.74.126.50]) by smtp.gmail.com with ESMTPSA id 202sm122297708pfy.87.2019.01.05.19.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jan 2019 19:45:56 -0800 (PST) From: Deng Xiaodong Message-Id: <143BAA4C-BA2B-4AF1-BBE4-60EBE162C721@gmail.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_50B21597-DA52-41AA-BDBA-0E8A28DB782A" Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: Travis CI reporting incorrectly Date: Sun, 6 Jan 2019 11:45:54 +0800 In-Reply-To: Cc: Tao Feng , "Driesprong, Fokko" To: dev@airflow.apache.org References: <67A68079-D3D8-4162-8E14-D017399DCB20@gmail.com> X-Mailer: Apple Mail (2.3445.6.18) --Apple-Mail=_50B21597-DA52-41AA-BDBA-0E8A28DB782A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=gb2312 Thanks Kaxil for fixing this. Obvious that some errors were introduced into Master branch in the last = few days during which the Travis CI was not working as expected. - Some of the fails were due to a logic error in `delete_dag`, which was = introduced into master branch in PR #4406 six days ago = (https://github.com/apache/airflow/pull/4406 = , `[AIRFLOW-3599] Removed = DagBag from delete dag`). I already prepared a PR to fix it = (https://github.com/apache/airflow/pull/4445 = , [AIRFLOW-3635] Fix = incorrect logic in delete_dag). This fix reduces fails & errors from =A1=B0= 8 FAILED, 2 errors=A1=B1 to =A1=B03 FAILED, 1 error=A1=B1. Please = review. - Other fails & errors are due to multiple reasons. One of them is that = test was not updated for PR # 4432 ([AIRFLOW-3622] Add ability to pass = hive_conf to HiveToMysqlTransfer = ). May anyone pick this up? Thanks. XD > On 5 Jan 2019, at 11:52 PM, Kaxil Naik wrote: >=20 > It is fixed now. I will merge that PR ( > https://github.com/apache/airflow/pull/4441) once the CI build = finishes. >=20 > It is now reporting error correctly. Can someone approve the PR? >=20 >=20 >=20 > On Sat, Jan 5, 2019 at 3:38 PM Naik Kaxil wrote: >=20 >> I have that in my PR but it still failed. I made another change and >> triggered the CI, let's see >>=20 >>=20 >> Kaxil Naik >>=20 >> Data Reply >> Nova South >> 160 Victoria Street, Westminster >> London SW1E 5LB - UK >> phone: +44 (0)20 7730 6000 >> k.naik@reply.com >> www.reply.com >>=20 >> [image: Data Reply] >> ------------------------------ >> *From:* Deng Xiaodong >> *Sent:* Saturday, January 5, 2019 3:20:57 PM >> *To:* dev@airflow.apache.org >> *Cc:* Tao Feng; Driesprong, Fokko >> *Subject:* Re: Travis CI reporting incorrectly >>=20 >> Hi Kaxil, >>=20 >> Not sure if you guys have found the root-cause. If not, I suspect = it=A1=AFs >> because of this line =A1=B0sudo ln -s ${ROOTDIR} >> /home/travis/build/apache/incubator-airflow=A1=B1 in >> = https://github.com/apache/airflow/blob/master/scripts/ci/5-run-tests.sh#L9= 7 >> = .= >> It was not updated accordingly in PR 4419. >>=20 >> Please check. >>=20 >> Thanks. >>=20 >>=20 >> XD >>=20 >>> On 5 Jan 2019, at 11:06 PM, Kaxil Naik wrote: >>>=20 >>> An Example is the latest build: >>> https://travis-ci.org/apache/airflow/jobs/475704671#L7363 >>>=20 >>> It had "8 FAILED, 2 errors, 40 skipped (2072 tests passed)" >>>=20 >>> But still the test show as successful. >>>=20 >>> On Sat, Jan 5, 2019 at 1:18 PM Kaxil Naik = wrote: >>>=20 >>>> Sorry - I meant I think it *is* because of the renaming of the = repo. >>>>=20 >>>> On Sat, Jan 5, 2019 at 1:14 PM Kaxil Naik = wrote: >>>>=20 >>>>> Hi guys, >>>>>=20 >>>>> Travis CI is reporting the build status incorrectly. Few of the = tests >>>>> have failed but it still shows the overall test as passed. >>>>>=20 >>>>> Request to all the committers to not merge any PR before going to >> Travis >>>>> and checking. >>>>>=20 >>>>> PS: I don't think it has anything to do with renaming for >>>>> incubator-airflow to airflow >>>>>=20 >>>>> Regards, >>>>>=20 >>>>> *Kaxil Naik* >>>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> *Kaxil Naik* >>>> *Big Data Consultant *@ *Data Reply UK* >>>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & >> Neo4j >>>> Developer >>>> *Phone: *+44 (0) 74820 88992 >>>> *LinkedIn*: https://www.linkedin.com/in/kaxil >>>>=20 >>>=20 >>>=20 >>> -- >>> *Kaxil Naik* >>> *Big Data Consultant *@ *Data Reply UK* >>> *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & = Neo4j >>> Developer >>> *Phone: *+44 (0) 74820 88992 >>> *LinkedIn*: https://www.linkedin.com/in/kaxil >>=20 >>=20 >=20 > --=20 > *Kaxil Naik* > *Big Data Consultant *@ *Data Reply UK* > *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & = Neo4j > Developer > *Phone: *+44 (0) 74820 88992 > *LinkedIn*: https://www.linkedin.com/in/kaxil --Apple-Mail=_50B21597-DA52-41AA-BDBA-0E8A28DB782A--