From dev-return-6922-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Oct 30 21:45:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F1BB7180652 for ; Tue, 30 Oct 2018 21:44:59 +0100 (CET) Received: (qmail 80552 invoked by uid 500); 30 Oct 2018 20:44:58 -0000 Mailing-List: contact dev-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list dev@airflow.incubator.apache.org Received: (qmail 80540 invoked by uid 99); 30 Oct 2018 20:44:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Oct 2018 20:44:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C5DA9C156D for ; Tue, 30 Oct 2018 20:44:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.888 X-Spam-Level: * X-Spam-Status: No, score=1.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mH7OZqEU0SjB for ; Tue, 30 Oct 2018 20:44:55 +0000 (UTC) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E19F25F188 for ; Tue, 30 Oct 2018 20:44:54 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id f1-v6so11762669edi.0 for ; Tue, 30 Oct 2018 13:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=7cfkjEyQi1JBrmGYPUBZ2/rejBpBTmxCid3OwTTJxGM=; b=JImanbtPFkGa+9rGzI3L+Oj+lXuzl50B0KndzrHqZXeePWeZpl6D87BwbDaSLUcyIZ HWFV4j/wzMDyqt6r7kj4xTfevSGFFrusEd1pfgacF5S6Aca+c8Ha69fqqt0JpBhZOHQO dHk7du9/SF4cqwbVabd1tj4UQoTdatmvmTOUzN99AlVS+yVb1+ijVcAqJy9FW4sj0pX7 XI89mdyAmrpYbBAjhfgx92DuydJHbuK8qQE94blzoPBuTw5pmrhCrYe24LCvavWSZeRm Yt89xDT2O77Ddm+PIuA+anLpQO9bCkaCkYyrqX4QjW9qBXuPao0ZYGsL4a8KI0wT5OZx QBUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=7cfkjEyQi1JBrmGYPUBZ2/rejBpBTmxCid3OwTTJxGM=; b=cksQYEMp4sYiEi4c5J2+SislSkoE0ZBnCSWdcTLK3dAz6iteUpW0/c6MJC0SfAPOD8 T7Z7xMlD6Plk37CqEd6sBnwm7MPpc/8L1eEwT1fg5DKYi+mz8SJ6qmt3NhA3PfHcT8sD KBXcIztYRfTrmKtAJwd9wWRoBZv9MHMvv/llr+zDm4jEjcNFCFyheqINcZJ73ugr0d4D dibP1oq/D0nec5J2HE7Rmkuk738VWhI8pyVmIShyBDUFa6pi+MtKgU4ohZoCnYBc4d83 Ey6i53Pbi0FbiOIOmdUZvtU4EQ0HBmvE+wMLN3M7lPNGEGKQPvHkc4puFPezgLqLp3OP /FVg== X-Gm-Message-State: AGRZ1gIckEZ6BT3ITgd9i/qxge7r27eVzUZrS+LBi3hHmC9UsHLCe2q9 AH5VwEYTn0mpcrjxtuREPuUQ9tI= X-Google-Smtp-Source: AJdET5eOzuZUi2iLebXTmGqdEWzHaOJBURViOJYW4liZYWQVB8BkVhlHWuc71qinsXy18wYj8d+edg== X-Received: by 2002:a17:906:a455:: with SMTP id cb21-v6mr87880ejb.185.1540932294447; Tue, 30 Oct 2018 13:44:54 -0700 (PDT) Received: from ?IPv6:2001:470:1f15:566:2095:dd92:4f4d:f043? ([2001:470:1f15:566:2095:dd92:4f4d:f043]) by smtp.gmail.com with ESMTPSA id w1-v6sm4479772ejz.40.2018.10.30.13.44.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 13:44:53 -0700 (PDT) From: Bolke de Bruin Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_ED37AD76-C32C-4897-9D0D-A46AE558DFBC" Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: 1.10.1 Release? Date: Tue, 30 Oct 2018 21:44:52 +0100 In-Reply-To: Cc: dev@airflow.incubator.apache.org To: Ash Berlin-Taylor References: <5DE7553C-D180-4AD6-815F-078637AF7EED@gmail.com> <48CE10E8-49AF-4AF7-A1E0-32AF239ED85A@gmail.com> <22AF3EDB-3FB2-4FDA-BCDD-AEE40411F19E@gmail.com> <3BC039E1-4512-454C-A17E-D1DBD524F3CA@apache.org> <82D7ABC6-ACB7-4650-AF3D-FDAEE80CB8AA@gmail.com> <3915D424-2E2C-48CC-AD05-85A09820B494@apache.org> <2C977D4C-0AD7-4769-813F-5B914123B8F0@gmail.com> <57BAABD0-4A83-4D63-ACEF-DE0F4308AF21@gmail.com> X-Mailer: Apple Mail (2.3445.100.39) --Apple-Mail=_ED37AD76-C32C-4897-9D0D-A46AE558DFBC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Patch available at: https://github.com/apache/incubator-airflow/pull/4117 please test. B. > On 30 Oct 2018, at 21:14, Bolke de Bruin wrote: >=20 > We should just pass it the UTC date (we should never use local time = except at the user interface). I=E2=80=99m testing a patch right now. >=20 > B. >=20 >> On 30 Oct 2018, at 21:13, Ash Berlin-Taylor > wrote: >>=20 >> I think if we give croniter a tz-aware DT in the local tz it will = deal with DST (i.e. will give 2:55 CEST followed by 2:00 CET) and then = we convert it to UTC for return - but right now we are giving it a = TZ-unaware local time. >>=20 >> I think. >>=20 >> Ash >>=20 >> On 30 October 2018 19:40:27 GMT, Bolke de Bruin > wrote: >> I think we should use the UTC date for cron instead of the naive = local date time. I will check of croniter implements this so we can rely = on that. >>=20 >> B. >>=20 >> On 28 Oct 2018, at 02:09, Bolke de Bruin > wrote: >>=20 >> I wonder how to treat this: >>=20 >> This is what I think happens (need to verify more, but I am pretty = sure) the specified DAG should run every 5 minutes. At DST change (3AM = -> 2AM) we basically hit a schedule that we have already seen. 2AM -> = 3AM has already happened. Obviously the intention is to run every 5 = minutes. But what do we do with the execution_date? Is this still = idempotent? Should we indeed reschedule?=20 >>=20 >> B. >>=20 >> On 30 Oct 2018, at 19:01, Ash Berlin-Taylor > wrote: >>=20 >> I've done a bit more digging - the issue is of our tz-aware handling = inside following_schedule (and previous schedule) - causing it to loop. >>=20 >> This section of the croniter docs seems relevant = https://github.com/kiorky/croniter#about-dst = >>=20 >> Be sure to init your croniter instance with a TZ aware datetime for = this to work !: >> local_date =3D tz.localize(datetime(2017, 3, 26)) >> val =3D croniter('0 0 * * *', local_date).get_next(datetime) >>=20 >> I think the problem is that we are _not_ passing a TZ aware dag in = and we should be. >>=20 >> On 30 Oct 2018, at 17:35, Bolke de Bruin > wrote: >>=20 >> Oh that=E2=80=99s a great environment to start digging. Thanks. = I=E2=80=99ll have a look. >>=20 >> B. >>=20 >> Verstuurd vanaf mijn iPad >>=20 >> Op 30 okt. 2018 om 18:25 heeft Ash Berlin-Taylor > het volgende geschreven: >>=20 >> This line in airflow.jobs (line 874 in my checkout) is causing the = loop: >>=20 >> last_run =3D dag.get_last_dagrun(session=3Dsession) >> if last_run and next_run_date: >> while next_run_date <=3D last_run.execution_date: >> next_run_date =3D = dag.following_schedule(next_run_date) >>=20 >>=20 >>=20 >> On 30 Oct 2018, at 17:20, Ash Berlin-Taylor > wrote: >>=20 >> Hi, kaczors on gitter has produced a minmal reproduction case: = https://github.com/kaczors/airflow_1_10_tz_bug = >>=20 >> Rough repro steps: In a VM, with time syncing disabled, and = configured with system timezone of Europe/Zurich (or any other CEST one) = run=20 >>=20 >> - `date 10280250.00` >> - initdb, start scheduler, webserver, enable dag etc. >> - `date 10280259.00` >> - wait 5-10 mins for scheduler to catch up >> - After the on-the-hour task run the scheduler will spin up another = process to parse the dag... and it never returns. >>=20 >> I've only just managed to reproduce it, so haven't dug in to why yet. = A quick hacky debug print shows something is stuck in an infinite loop. >>=20 >> -ash >>=20 >> On 29 Oct 2018, at 17:59, Bolke de Bruin > wrote: >>=20 >> Can this be confirmed? Then I can have a look at it. Preferably with = dag definition code. >>=20 >> On the licensing requirements: >>=20 >> 1. Indeed licensing header for markdown documents. It was suggested = to use html comments. I=E2=80=99m not sure how that renders with others = like PDF though. >> 2. The licensing notifications need to be tied to a specific version = as licenses might change with versions. >>=20 >> Cheers >> Bolke >>=20 >> Verstuurd vanaf mijn iPad >>=20 >> Op 29 okt. 2018 om 12:39 heeft Ash Berlin-Taylor > het volgende geschreven: >>=20 >> I was going to make a start on the release, but two people have = reported that there might be an issue around non-UTC dags and the = scheduler changing over from Summer time. >>=20 >> 08:45 Emmanuel> Hi there, we are currently experiencing a very = strange issue : we have hourly DAGs with a start_date in a local = timezone (not UTC) and since (Sunday) the last winter time change they = don=E2=80=99t run anymore. Any idea ? >> 09:41 it impacted all our DAG that had a run at 3am = (Europe/Paris), the exact time of winter time change :( >>=20 >> I am going to take a look at this today and see if I can get to the = bottom of it. >>=20 >> Bolke: are there any outstanding tasks/issues that you know of that = might slow down the vote for a 1.10.1? (i.e. did we sort of out all the = licensing issues that were asked of us? I thought I read something about = license declarations in markdown files?) >>=20 >> -ash >>=20 >> On 28 Oct 2018, at 14:46, Bolke de Bruin > wrote: >>=20 >> I agree with that, but I would favor time based releases instead. We = are again at the point that a release takes so much time that the gap is = getting really big again. @ash why not start releasing now and move the = remainder to 1.10.2? I dont think there are real blockers (although we = might find them). >>=20 >>=20 >> On 28 Oct 2018, at 15:35, airflowuser = > wrote: >>=20 >> I was really hoping that = https://github.com/apache/incubator-airflow/pull/4069 = will be merged = into 1.10.1 >> Deleting dags was a highly requested feature for 1.10 - this can fix = the problem with it. >>=20 >>=20 >> =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 = Original Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2= =80=90 >> On Friday, October 26, 2018 6:12 PM, Bolke de Bruin = > wrote: >>=20 >> Hey Ash, >>=20 >> I was wondering if you are picking up the 1.10.1 release? Master is = speeding ahead and you were tracking fixes for 1.10.1 right? >>=20 >> B. >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >> --=20 >> Sent from my Android device with K-9 Mail. Please excuse my brevity. >=20 --Apple-Mail=_ED37AD76-C32C-4897-9D0D-A46AE558DFBC--