airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ash Berlin-Taylor <...@apache.org>
Subject Re: Running unit tests against SLUGIFY_USES_TEXT_UNIDECODE and AIRFLOW_GPL_UNIDECODE (also is this broken?)
Date Wed, 29 Aug 2018 09:01:51 GMT
I don't think we strictly care about running the tests in both these circumstances - it is
a flag that control which dep is installed two or three levels down as you say, and the project
has it's own tests.

I'd rather we spent time on replacing python-nvd with something that means we don't have
to force our users to install it in a slightly odd way, and instead can just `pip install
apache-airflow` again.

The reason this setting might not make any difference to what is installed comes down to Python
Wheels - i.e. binary packages. When pip installs a wheel (which it does for preference as
it is quicker) it doesn't run that project's setup.py anymore, so this block https://github.com/un33k/python-slugify/blob/master/setup.py#L18-L21
<https://github.com/un33k/python-slugify/blob/master/setup.py#L18-L21> isn't run.

The fix if you want to make it run this block still is `pip install --no-binary=python-slugify
apache-airflow`

> On 28 Aug 2018, at 21:18, Taylor Edmiston <tedmiston@gmail.com> wrote:
> 
> Since the release of 1.10, we now have the option to install Airflow with
> either:
> 
> 1. python-nvd3 <https://github.com/areski/python-nvd3> --> python-slugify
> <https://github.com/un33k/python-slugify> --> text-unidecode
> <https://github.com/kmike/text-unidecode/> (via env var
> SLUGIFY_USES_TEXT_UNIDECODE=yes), or
> 2. python-nvd3 --> python-slugify --> unidecode
> <https://github.com/avian2/unidecode> (via AIRFLOW_GPL_UNIDECODE=yes)
> 
> Currently on Travis CI we only test the former configuration.  Does anyone
> have a recommendation on how to go about testing the latter?  Running an
> entire second copy of the unit tests for one dependency feels a bit
> redundant... maybe there's a small relevant subset of tests that could only
> run for the alternative dependency config?
> 
> On a related note, I think this part of the install may be broken.
> 
> I've tried running a pip install under each config like so (using pyenv +
> virtualenvwrapper):
> 
> Shell 1:
> 
> pyenv shell 3.6.5
> mktmpenv
> export SLUGIFY_USES_TEXT_UNIDECODE=yes
> pip install apache-airflow
> pip freeze > ~/a.txt
> 
> Shell 2:
> 
> pyenv shell 3.6.5
> mktmpenv
> export AIRFLOW_GPL_UNIDECODE=yes
> pip install apache-airflow
> pip freeze > ~/b.txt
> 
> Shell 3:
> 
> diff ~/a.txt ~/b.txt
> (empty)
> 
> I would expect the former to have text-unidecode and the latter to have
> Unidecode.  *Can someone else attempt to reproduce this behavior?*
> 
> Additionally, I'm also experiencing this same behavior when trying to
> install the underlying python-slugify package similarly as well.  I've
> opened an issue for that here -
> https://github.com/un33k/python-slugify/issues/59.
> 
> Thank you,
> Taylor
> 
> *Taylor Edmiston*
> Blog <https://blog.tedmiston.com/> | CV
> <https://stackoverflow.com/cv/taylor> | LinkedIn
> <https://www.linkedin.com/in/tedmiston/> | AngelList
> <https://angel.co/taylor> | Stack Overflow
> <https://stackoverflow.com/users/149428/taylor-edmiston>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message