From dev-return-5733-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Jul 31 18:49:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2C0FC180662 for ; Tue, 31 Jul 2018 18:49:27 +0200 (CEST) Received: (qmail 27768 invoked by uid 500); 31 Jul 2018 16:49:22 -0000 Mailing-List: contact dev-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list dev@airflow.incubator.apache.org Received: (qmail 27753 invoked by uid 99); 31 Jul 2018 16:49:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2018 16:49:22 +0000 From: GitBox To: dev@airflow.apache.org Subject: [GitHub] tedmiston commented on a change in pull request #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues Message-ID: <153305576155.5392.15031382516687919655.gitbox@gitbox.apache.org> Date: Tue, 31 Jul 2018 16:49:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit tedmiston commented on a change in pull request #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#discussion_r206602944 ########## File path: airflow/www_rbac/static/js/clock.js ########## @@ -18,24 +18,25 @@ */ require('./jqClock.min'); -$(document).ready(function () { - x = new Date(); +$(document).ready(() => { Review comment: Sounds good. I will stick with the ES5 for now for this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services