airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deng Xiaodong <xd.den...@gmail.com>
Subject Re: Unused Arguments in ***Executor.execute_async() Method
Date Tue, 31 Jul 2018 23:31:03 GMT
Thanks Taylor for your reply! Makes sense to me.

XD

On Wed, Aug 1, 2018 at 05:07 Taylor Edmiston <tedmiston@gmail.com> wrote:

> I believe that function signature is kept consistent across all executors
> from the definition in BaseExecutor.
>
>
> https://github.com/apache/incubator-airflow/blob/846e2746c0be3d9e55edd3351ae9f43228ea48a5/airflow/executors/base_executor.py#L184-L192
>
> You can see for example that CeleryExecutor uses queue and
> KubernetesExecutor uses executor_config.
>
>
> https://github.com/apache/incubator-airflow/blob/fcd51f362c6804cb69dee8e2dd054304a0564dde/airflow/executors/celery_executor.py#L81
>
>
> https://github.com/apache/incubator-airflow/blob/4cfebd8aed6acd64b34daa983413f60552e671ec/airflow/contrib/executors/kubernetes_executor.py#L573
>
> Best,
> Taylor
>
> *Taylor Edmiston*
> Blog <https://blog.tedmiston.com/> | CV
> <https://stackoverflow.com/cv/taylor> | LinkedIn
> <https://www.linkedin.com/in/tedmiston/> | AngelList
> <https://angel.co/taylor> | Stack Overflow
> <https://stackoverflow.com/users/149428/taylor-edmiston>
>
>
> On Tue, Jul 31, 2018 at 11:35 AM, Deng Xiaodong <xd.deng.r@gmail.com>
> wrote:
>
> > Hi there,
> >
> > I'm checking the implementation of executors, and encountered a question
> > which may be a bit naive.
> >
> > In ****Executor.execute_async()* Methods, say
> LocalExecutor.execute_async()
> > (
> > https://github.com/apache/incubator-airflow/blob/master/
> > airflow/executors/local_executor.py#L224),
> > there are two arguments *queue* and *executor_config* which are not used
> at
> > all inside this method.
> >
> > I'm not sure if there is any special purpose, prospective design, or
> simply
> > I misunderstood the code?
> >
> > Thanks for your answers in advance!
> >
> > Best regards,
> > XD
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message