airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tedmiston commented on a change in pull request #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues
Date Tue, 31 Jul 2018 16:49:21 GMT
tedmiston commented on a change in pull request #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues
URL: https://github.com/apache/incubator-airflow/pull/3656#discussion_r206602944
 
 

 ##########
 File path: airflow/www_rbac/static/js/clock.js
 ##########
 @@ -18,24 +18,25 @@
  */
 require('./jqClock.min');
 
-$(document).ready(function () {
-  x = new Date();
+$(document).ready(() => {
 
 Review comment:
   Sounds good.  I will stick with the ES5 for now for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message