airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] verdan commented on a change in pull request #3656: [AIRFLOW-2803] Fix all ESLint issues
Date Tue, 31 Jul 2018 08:47:39 GMT
verdan commented on a change in pull request #3656: [AIRFLOW-2803] Fix all ESLint issues
URL: https://github.com/apache/incubator-airflow/pull/3656#discussion_r206443837
 
 

 ##########
 File path: airflow/www_rbac/static/js/clock.js
 ##########
 @@ -18,24 +18,25 @@
  */
 require('./jqClock.min');
 
-$(document).ready(function () {
-  x = new Date();
+$(document).ready(() => {
 
 Review comment:
   Please note that most of the custom JS is written inline in .html files, and we are not
yet considering that javascript in webpack, that means, we won't be able to transpile that
javascript to ES5. (which is fine for now)
   I am working on another issue to extract all inline JS from html files to separate .js
files. 
   https://issues.apache.org/jira/browse/AIRFLOW-2804
   
   My suggestion would be to implement the ES6->ES5 tranpilation as part of this issue.
And once this PR gets merged, we'll be able to extract all inline JS into separate .js files.

   We already have a JIRA issue for that: https://issues.apache.org/jira/browse/AIRFLOW-2730

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message