From dev-return-5338-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Jun 5 19:08:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 93E70180625 for ; Tue, 5 Jun 2018 19:08:58 +0200 (CEST) Received: (qmail 96025 invoked by uid 500); 5 Jun 2018 17:08:57 -0000 Mailing-List: contact dev-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list dev@airflow.incubator.apache.org Delivered-To: moderator for dev@airflow.incubator.apache.org Received: (qmail 86155 invoked by uid 99); 5 Jun 2018 17:03:10 -0000 x-ponymail-agent: PonyMail Composer/0.3 X-Mailer: LuaSocket 3.0-rc1 Date: Tue, 05 Jun 2018 17:03:09 -0000 Subject: Python3 and Pig Hook Message-ID: x-ponymail-sender: 281c30537ad4766918876ae17cdcd9f73a2d5d73 Content-Type: text/plain; charset=utf-8 From: miqbal88@gmail.com To: In-Reply-To: References: MIME-Version: 1.0 Hi, I have a small update for the Pig Hook to make it compatible with Python3, and it seems complicated to set up a test for, b/c I would have to configure Pig in a testing suite. I noticed there weren't any tests for it listed before. Would it be okay for me to skip the test in this case? Could I have some guidance? My change is just to explicitly cast strings to byte arrays: https://github.com/overstock/incubator-airflow/commit/8bb729c358ae13a9f7f5408b0a26e19b29a132ec There is additional information available here: https://stackoverflow.com/questions/50652034/pig-hook-in-airflow-doesnt-work-for-python3 Thank you, Murium