airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miqbal88@gmail.com <miqba...@gmail.com>
Subject Python3 and Pig Hook
Date Tue, 05 Jun 2018 17:03:09 GMT
Hi,

I have a small update for the Pig Hook to make it compatible with Python3, and it seems complicated
to set up a test for, b/c I would have to configure Pig in a testing suite. I noticed there
weren't any tests for it listed before. Would it be okay for me to skip the test in this case?
Could I have some guidance?

My change is just to explicitly cast strings to byte arrays:
https://github.com/overstock/incubator-airflow/commit/8bb729c358ae13a9f7f5408b0a26e19b29a132ec

There is additional information available here:
https://stackoverflow.com/questions/50652034/pig-hook-in-airflow-doesnt-work-for-python3

Thank you,
Murium

Mime
View raw message