From dev-return-4662-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Thu Mar 8 15:31:36 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF50818064C for ; Thu, 8 Mar 2018 15:31:35 +0100 (CET) Received: (qmail 65455 invoked by uid 500); 8 Mar 2018 14:31:34 -0000 Mailing-List: contact dev-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list dev@airflow.incubator.apache.org Received: (qmail 65429 invoked by uid 99); 8 Mar 2018 14:31:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2018 14:31:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 837BEC00CB for ; Thu, 8 Mar 2018 14:31:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.011 X-Spam-Level: X-Spam-Status: No, score=-0.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mFWOrxhAvO3O for ; Thu, 8 Mar 2018 14:31:30 +0000 (UTC) Received: from mail.firemirror.com (mail.firemirror.com [178.63.242.223]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 53AE55F5E1 for ; Thu, 8 Mar 2018 14:31:30 +0000 (UTC) Received: from [217.169.25.231] (helo=[192.168.152.66]) by mail.firemirror.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1etwZj-0000Cp-Ba for dev@airflow.incubator.apache.org; Thu, 08 Mar 2018 14:31:24 +0000 From: Ash Berlin-Taylor Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide? Date: Thu, 8 Mar 2018 14:31:18 +0000 References: <281CF07E-0AC7-4069-A19C-E3FA6DCB0E96@firemirror.com> To: dev@airflow.incubator.apache.org In-Reply-To: <281CF07E-0AC7-4069-A19C-E3FA6DCB0E96@firemirror.com> Message-Id: <5C7A6670-E8C9-46DE-A291-2856F87A2F18@firemirror.com> X-Mailer: Apple Mail (2.3273) I've done a bit of digging and there's an Apache "project" called = gitbox[1] that, if we choose to go that way lets us use Github more = "natively". The BookKeeper project migrated to using Github exclusively lsat Jun[2] = and from the looks of their Github repo are still using this approach, = and their Jira is read only. Their proposal on the migration was = https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-9+-+Github+issue= s+for+Issue+Tracking I think there are three ways we could go: 1. Nothing changes, we stay as we are and commit to the ASF git repo. 2. Move to Gitbox and commit directly to githb, keep issues in Jira. 3. Do as BookKeeper did and move to using Github Issues as well as Gitub = for the repo.=20 Is there interest from anyone else in 2 or 3, if so I will attempt to = draw up a more detailed proposal. [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv [2]: = http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201706.mbox/%3CCAO= 2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com%3E=20 > On 6 Mar 2018, at 09:57, Ash Berlin-Taylor = wrote: >=20 > Ah that would explain why I don't have a button :) >=20 > Is this Apache policy, or is it possible for committers to be granted = permission to do this? Having this permission would also let us click = the "rerun tests" button in Travis which would be nice. >=20 > Is it worth opening an INFRA ticket asking for this, or is it not = possible? >=20 > -ash >=20 >> On 6 Mar 2018, at 08:25, Driesprong, Fokko = wrote: >>=20 >> Hi Ash, >>=20 >> As a committer we don't have any rights on the Github itself. The = Github >> repo is just a sync of the apache repo. Unfortunately, therefore we = don't >> have the right to close any PR. >>=20 >> Cheers, Fokko >>=20 >> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor = >> : >>=20 >>> I've merged two PRs now, and the second one seemed to be better = (though I >>> did have some trouble with the tool not merging properly and I = needed to >>> manually coax git. Hmm) >>>=20 >>> Jira: I _think_ that previously I could only comment on Jira issues. = With >>> the new permissions I can now do more (as those of you subscribed to = the >>> commit list will see) -- I started going through old Jira tickets = and >>> closing ones that are no longer an issue or that were fixed+merged = but not >>> closed. >>>=20 >>> Github: I don't have a button to close PRs in Github - Is that = expected? >>>=20 >>> -ash >>>=20 >>>=20 >>>> On 4 Mar 2018, at 00:59, Sid Anand wrote: >>>>=20 >>>> Hi Ash, >>>> Welcome aboard. >>>>=20 >>>> Firstly, I'm moving this conversation over to the dev list -- the = first >>>> lesson we all learned at the insistence of the incubator mentors = was to >>> use >>>> the private list for voting and discussion on PMC matters. They = require >>>> that all information-oriented discussions be routed to the = dev-list. >>>>=20 >>>> *Merging PRs:* >>>> To merge a PR, you can use a very handy tool written by @jlowin >>>> : https://github.com/apache/ >>>> incubator-airflow/blob/master/dev/airflow-pr >>>>=20 >>>> It's pretty self-explanatory. Essentially, you follow the = instructions in >>>> the tool -- the result is that the PR will be merged to Apache >>>> and = then >>>> synced (mirrored) to https://github.com/apache/incubator-airflow. = The >>>> Apache mirror runs on apache infrastructure and is the source of = truth >>>> (rules of apache). The mirror >> incubator-airflow> >>>> is what we all see.. there can sometimes be a delay of a minute = before >>> the >>>> PR you merged shows up in the commit history on git hub, but it's = usually >>>> under 10 seconds. >>>>=20 >>>> We document the tool on the Committer Guide >>>> = >>> . >>>>=20 >>>> *Releases:* >>>> As I haven't done a release yet, I'll defer to Bolke and Chris who = most >>>> recently did releases to point you to documentation. >>>>=20 >>>> *Jira Role:* >>>> I've added you to the Admin, PMC, Committers, and ASF Members = roles. I >>>> believe you don't need them to edit or close and JIRAs. I had = requested >>>> anyone be able to open, edit, or close JIRAs, so if that's not the = case, >>> it >>>> would be good to know. >>>>=20 >>>> *GitHub:* >>>> Can you try merging a PR? That would be an indication that you have = the >>>> necc perms. >>>>=20 >>>> *Other Questions*: >>>> Q1:"I understand that the process for making changes now I'm a = committer >>> is >>>> the same as before: I should open a PR+Jira and get it approved by >>> another >>>> committer. Is this correct?" >>>> A1: You are correct! >>>>=20 >>>> Hope this helps! >>>> -s >>>>=20 >>>> P.S. >>>> BTW, I'll be in London from tomorrow (landing at noon) till the = following >>>> Friday -- I co-chair QCon London and usually find myself there = around >>> this >>>> time every year. Feel free to drop me a line if you happen to be in = the >>>> area. >>>>=20 >>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor >>> wrote: >>>>=20 >>>>> Hi Everyone! >>>>>=20 >>>>> Thanks for inviting me to join the Airflow PPMC! >>>>>=20 >>>>> An introduction: I live and work in London, I'm currently working = for >>> the >>>>> data group of a large advertising company, though I will be going = on >>>>> paternity leave for 3 months any day now as my wife is pregnant = with our >>>>> first child. (Eeee!) >>>>>=20 >>>>> I have some questions :) >>>>>=20 >>>>> How to I merge PRs? =46rom the outside it appears that the merge = happens >>> in >>>>> an apache repo and is somehow automatically replicated into = github. Is >>>>> there a guide on the workflow to do this? What credentials do I = use for >>>>> apache git? >>>>>=20 >>>>> Is the branching process for releases or it is it a loose = convention up >>> to >>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test >>> etc.) If >>>>> we wanted to release a 1.9.1 with some fixes what might the = process be? >>>>>=20 >>>>> Can someone grant my Jira user (ashb) permission to edit/close = tickets? >>>>>=20 >>>>> Ditto for github (ashb)? >>>>>=20 >>>>> I understand that the process for making changes now I'm a = committer is >>>>> the same as before: I should open a PR+Jira and get it approved by >>> another >>>>> committer. Is this correct? >>>>>=20 >>>>> Is there anything else I should know but don't know about to ask? = :) >>>>>=20 >>>>> Thanks, >>>>> Ash >>>=20 >>>=20 >=20