From dev-return-4410-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Fri Jan 12 23:26:21 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DB311180621 for ; Fri, 12 Jan 2018 23:26:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CB4E8160C33; Fri, 12 Jan 2018 22:26:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18030160C20 for ; Fri, 12 Jan 2018 23:26:20 +0100 (CET) Received: (qmail 98386 invoked by uid 500); 12 Jan 2018 22:26:20 -0000 Mailing-List: contact dev-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list dev@airflow.incubator.apache.org Received: (qmail 98375 invoked by uid 99); 12 Jan 2018 22:26:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 22:26:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8639BC1F55 for ; Fri, 12 Jan 2018 22:26:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.031 X-Spam-Level: X-Spam-Status: No, score=-3.031 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Xh3AfZw1XkBX for ; Fri, 12 Jan 2018 22:26:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 802215F24C for ; Fri, 12 Jan 2018 22:26:17 +0000 (UTC) Received: (qmail 98372 invoked by uid 99); 12 Jan 2018 22:26:16 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 22:26:16 +0000 Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 686871A00A0 for ; Fri, 12 Jan 2018 22:26:14 +0000 (UTC) Received: by mail-wr0-f173.google.com with SMTP id 16so6524789wry.12 for ; Fri, 12 Jan 2018 14:26:13 -0800 (PST) X-Gm-Message-State: AKwxytdnJdvYplJz74iT5ppV0yLH7qPniTy9mGvUGpKP8275RUywXjKX sUHis3HtrcHplG8IbS+n8SSsSWK/bMQ0yI2RJZo= X-Google-Smtp-Source: ACJfBosZhDwxJODEStKR04MyWYCAXhYO33PRz7dkn3+Wxq33j1bM+Fqyzp9VywjEpwcg1AH9Rz+b0iTzQHOKUC5KDEE= X-Received: by 10.223.165.30 with SMTP id i30mr3182795wrb.84.1515795972058; Fri, 12 Jan 2018 14:26:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.160.23 with HTTP; Fri, 12 Jan 2018 14:25:41 -0800 (PST) In-Reply-To: References: From: Arthur Wiedmer Date: Fri, 12 Jan 2018 14:25:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: PR Review request for url_prefix To: dev@airflow.incubator.apache.org Content-Type: multipart/alternative; boundary="f403045f19f677759305629bc07f" --f403045f19f677759305629bc07f Content-Type: text/plain; charset="UTF-8" Gaetan, I did a quick review. Overall the changes look good. A couple of things to check. Best, Arthur On Sat, Jan 6, 2018 at 1:46 AM, Gaetan Semet wrote: > Hello > > Can a core developer look at my pull request ? > https://github.com/apache/incubator-airflow/pull/2723 > > Thanks > Gaetan > > On 2017-12-10 14:37, Sergei Iakhnin wrote: > > This feature sounds very useful. I hope you get your PR in soon. > > > > On Sat, Dec 9, 2017 at 7:59 PM Gaetan Semet wrote: > > > > > Hello > > > > > > Sorry to insist on my PR review, but it seems it can help some people: > > > https://github.com/apache/incubator-airflow/pull/2723# > issuecomment-350356492 > > > > > > For recall, this allows to easily set up airflow as url such as > > > > > > https://lab.mycompany.com/myorg/airflow/ > > > > > > and flower in > > > > > > https://lab.mycompany.com/myorg/airflow/flower > > > > > > API will be accessible at > > > > > > https://lab.mycompany.com/myorg/airflow/api/experimental/... > > > > > > Thanks > > > > > > Gaetan Semet > > > > > -- > > > > Sergei > > > --f403045f19f677759305629bc07f--