airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arthur Wiedmer <art...@apache.org>
Subject Re: PR Review request for url_prefix
Date Fri, 12 Jan 2018 22:25:41 GMT
Gaetan,

I did a quick review. Overall the changes look good. A couple of things to
check.

Best,
Arthur

On Sat, Jan 6, 2018 at 1:46 AM, Gaetan Semet <gaetan@xeberon.net> wrote:

> Hello
>
> Can a core developer look at my pull request ?
> https://github.com/apache/incubator-airflow/pull/2723
>
> Thanks
> Gaetan
>
> On 2017-12-10 14:37, Sergei Iakhnin <llevar@gmail.com> wrote:
> > This feature sounds very useful. I hope you get your PR in soon.
> >
> > On Sat, Dec 9, 2017 at 7:59 PM Gaetan Semet <gaetan@xeberon.net> wrote:
> >
> > > Hello
> > >
> > > Sorry to insist on my PR review, but it seems it can help some people:
> > > https://github.com/apache/incubator-airflow/pull/2723#
> issuecomment-350356492
> > >
> > > For recall, this allows to easily set up airflow as url such as
> > >
> > > https://lab.mycompany.com/myorg/airflow/
> > >
> > > and flower in
> > >
> > > https://lab.mycompany.com/myorg/airflow/flower
> > >
> > > API will be accessible at
> > >
> > > https://lab.mycompany.com/myorg/airflow/api/experimental/...
> > >
> > > Thanks
> > >
> > > Gaetan Semet
> > >
> > --
> >
> > Sergei
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message