airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bolke de Bruin <bdbr...@gmail.com>
Subject Re: Enabling flake8
Date Thu, 30 Nov 2017 15:58:42 GMT
It is enabled now for diffs. Strict, maximum line length 90.

Looking forward to cleaner code ;-).

Bolke.

> On 28 Nov 2017, at 03:12, Maxime Beauchemin <maximebeauchemin@gmail.com> wrote:
> 
> A colleague recently did something similar for Superset. I'm really glad we
> did.  We started by adding an exclusion list in `tox.ini`, and then knocked
> each exclusion rule by one in a set of PRs.
> 
> I like the idea of flaking on the diff as well. We'll be making sure that
> every line that gets touched in a PR is pristine moving forward.
> 
> +1 on breaking the build when there's any lint on any line touched in the
> PR.
> 
> Max
> 
> On Mon, Nov 27, 2017 at 7:48 AM, Driesprong, Fokko <fokko@driesprong.frl>
> wrote:
> 
>> Hi Bolke,
>> 
>> Great initiative. This should also help improve the quality of the PR's.
>> Let me know if you need any help.
>> 
>> Cheers, Fokko
>> 
>> 2017-11-27 16:47 GMT+01:00 Bolke de Bruin <bdbruin@gmail.com>:
>> 
>>> Hi All,
>>> 
>>> I just wanted to let you know, I am working on enabling flake8 tests. It
>>> should only cover new PRs and not existing code. So we should gradually
>>> improve our existing code base ;-).
>>> 
>>> Cheers
>>> Bolke
>> 


Mime
View raw message