airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From siddharth anand <san...@apache.org>
Subject Re: Call to Committers : PR Clean up Duty : ETA Nov 15
Date Wed, 12 Oct 2016 19:38:30 GMT
Max,
Thanks for adding to the list.
https://cwiki.apache.org/confluence/display/AIRFLOW/Cold-Case+PR+Resolution


If you're a committer on Airflow, please read closely.

I would like us to commit to reviewing PRs within 2 weeks. 90% of our PRs
were older than that as per an earlier email. That's resulting in an bad
experience for our community and contributors. Before we can make that
commitment, we need to clean up what are mostly abandoned PRs.

Please do the following at your earliest:

   - Pick 10 PRs opened before Oct 2
   - Review it. If the PR is ready to merge, please test and merge it
   - In most cases, the PRs require some action from the submitters
      - Comment on the PR asking the submitter to update the PR
      - If the submitter does not respond within a week, you can close the
      PR with comments such as "PR abandoned by submitter" or "no movement
      from submitter"
      - If the submitter responds and keeps the PR alive, please work with
      them
   - If you are a contributor, please work with the committers to bring
   your PRs to a positive outcome

We currently have <100 open PRs now and are many of you have already
started working on this.

Bolke, Chris, Dan (aeon), Patrick, Steven : Please update the wiki above at
your earliest convenience.

Contributors,
If you have thoughts on this process, please share them.

-s

On Tue, Oct 11, 2016 at 8:41 AM, siddharth anand <sanand@apache.org> wrote:

> Aoen, max?
>
>
> On Monday, October 10, 2016, siddharth anand <sanand@apache.org> wrote:
>
>> Great! Yep, Nov 15th.
>>
>> Thx Arthur and best of luck on your imminent deadline.
>>
>> -s
>>
>> On Mon, Oct 10, 2016 at 10:26 AM, Arthur Wiedmer <arthur@apache.org>
>> wrote:
>>
>>> The deadline is November 15th, not October 15th, right?
>>>
>>> I am finishing a big unrelated project here by the end of the week and
>>> will take some time for Airflow afterwards. Just so Sid is reassured
>>> ;p
>>>
>>>
>>> Best,
>>> Arthur
>>>
>>> On Sat, Oct 8, 2016 at 9:59 AM, siddharth anand <sanand@apache.org>
>>> wrote:
>>> > Excellent.. thanks for committing to that. Are any of the Airbnb folks
>>> > (Arthur, Dan, Max, Patrick) able to help out?
>>> >
>>> > -s
>>> >
>>> > On Sat, Oct 8, 2016 at 2:25 AM, Sumit Maheshwari <msumit@apache.org>
>>> wrote:
>>> >
>>> >> Hi Sid,
>>> >>
>>> >> I've also picked up my share.
>>> >>
>>> >>
>>> >> Thanks,
>>> >> Sumit
>>> >>
>>> >> On Fri, Oct 7, 2016 at 8:11 AM, siddharth anand <sanand@apache.org>
>>> wrote:
>>> >>
>>> >> > Folks!
>>> >> >
>>> >> > I've changed the title of the wiki to "*Cold Case PR Resolution*"
>>> >> > https://cwiki.apache.org/confluence/display/AIRFLOW/
>>> >> > Cold-Case+PR+Resolution.
>>> >> >
>>> >> > *Zodiac* and *Jlowin* have signed up for cold-case PRs. I need
the
>>> other
>>> >> > committers to also add to the list.
>>> >> >
>>> >> > *As committers on this project, we should aim to resolve all PRs
>>> within 2
>>> >> > weeks, *if we hope to keep the community happy and the project
>>> healthy!
>>> >> >
>>> >> > Here are some disturbing stats:
>>> >> >
>>> >> >    - Currently, of the currently *106 *open PRs, *8* were opened
in
>>> the
>>> >> >    past 2 weeks & *20* were opened within the past month
>>> >> >       - *90% of our PRs are over 2 weeks old*
>>> >> >       - *81% of our PRs are over 1 month old*
>>> >> >
>>> >> > These cold-case PRs will never be looked at again and their
>>> submitters
>>> >> will
>>> >> > likely not submit new fixes.
>>> >> >
>>> >> > I'm noticing a slow down in commits and PRs being opened, which
is
>>> likely
>>> >> > due to the fact that we haven't been able to keep up with the PR
>>> volume.
>>> >> > Some people believe that having a lot of open PRs is a sign of
a
>>> healthy
>>> >> > project. I'd qualify that statement as having "a lot of recently
>>> opened
>>> >> PRs
>>> >> > is a sign of a healthy project"
>>> >> >
>>> >> > If you are a committer on this project, please pick up 10 CCPRs
&
>>> add
>>> >> them
>>> >> > to the list.
>>> >> > -s
>>> >> >
>>> >> >
>>> >> >
>>> >> >
>>> >> > On Tue, Oct 4, 2016 at 1:05 PM, siddharth anand <sanand@apache.org>
>>> >> wrote:
>>> >> >
>>> >> > > I've added my 10 to https://cwiki.apache.org/co
>>> >> > > nfluence/display/AIRFLOW/Whittling+down+PR+List
>>> >> > >
>>> >> > >  Li Xuanji, Sumit, Dan, Arthur, Max, Bolke, Chris, Jeremiah
et al
>>> >> please
>>> >> > > add yours to the list.
>>> >> > >
>>> >> > > On Sun, Oct 2, 2016 at 9:57 AM, siddharth anand <
>>> sanand@apache.org>
>>> >> > wrote:
>>> >> > >
>>> >> > >> Hi Folks,
>>> >> > >> We have in excess of a 100 open PRs. We have 11 committers.
>>> Though
>>> >> > having
>>> >> > >> a lot of open PRs is a sign of a healthy project, the
majority
>>> of our
>>> >> > PRs
>>> >> > >> are over 3 months old - that's really not a healthy sign.
>>> >> > >>
>>> >> > >> This is a call to committers to help whittle down this
list. I'd
>>> like
>>> >> > >> each committer to take responsibility for 10 PRs from
the
>>> current list
>>> >> > (opened
>>> >> > >> before Oct 2) and help get them to a point of closure
by
>>> *November
>>> >> 15*.
>>> >> > >>
>>> >> > >> Some of these might be cold cases.. and will require
>>> contributors to
>>> >> > >> respond in a timely fashion. If you are a contributor
and don't
>>> >> respond
>>> >> > to
>>> >> > >> request for PR changes in this timeframe, there is a chance
that
>>> your
>>> >> PR
>>> >> > >> will be closed.
>>> >> > >>
>>> >> > >> To keep us honest, I've created the following list :
>>> >> > >> https://cwiki.apache.org/confluence/display/AIRFLOW/Whittl
>>> >> > >> ing+down+PR+List
>>> >> > >>
>>> >> > >> As you take on PRs from this list, please track them on
this
>>> CWiki.
>>> >> > >>
>>> >> > >> -s
>>> >> > >>
>>> >> > >
>>> >> > >
>>> >> >
>>> >>
>>>
>>
>>
>
> --
> Sent from Gmail Mobile
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message