airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Riccomini <criccom...@apache.org>
Subject Re: Getting to an Apache release
Date Thu, 16 Jun 2016 20:31:39 GMT
Hey all,

A PR has come in to fix all license headers (thanks, Ajay!):

  https://github.com/apache/incubator-airflow/pull/1598

I'm going to give one day to voice why we shouldn't merge in. If no one
yells, I'll merge tomorrow AM (PST).

Cheers,
Chris

On Wed, Jun 15, 2016 at 1:43 PM, Jakob Homan <jghoman@gmail.com> wrote:

> May as well.  Technically headers have to be added to anything where
> human creativity was involved (ie, not in generated source code), so
> one could argue they're not necessary in __init__.pys.  A lot of
> projects will use tools to verify that headers are present in source
> files, it'll probably be easier to add the header to the empty files
> than to configure the tool to ignore them.
>
> -jg
>
>
> On 15 June 2016 at 10:37, Ajay Yadav <ajaynsit@gmail.com> wrote:
> > I can take a stab at writing a script and sending a pull request for #2.
> > Should we add license headers to empty __init__.py as well? Shall I
> create
> > a JIRA for it(I couldn't find an already existing one)?
> >
> > On Wed, Jun 15, 2016 at 1:17 AM, Jeremiah Lowin <jlowin@apache.org>
> wrote:
> >
> >> Related to #2, I am dusting off AIRFLOW-31 (
> >> https://github.com/apache/incubator-airflow/pull/1272), which also
> >> includes
> >> about 50 license headers. I rebased it today and am waiting for travis
> to
> >> finish...
> >>
> >>
> >> On Tue, Jun 14, 2016 at 2:15 PM Bolke de Bruin <bdbruin@gmail.com>
> wrote:
> >>
> >> > Nice! Why don’t we also merge 1 into master then and fix issues from
> >> > there? It will get wider exposure (We run master in our dev
> environments
> >> > for example), it won’t put everything into the lab or Airbnb. Master
> >> hardly
> >> > should be considered production so imho it is allowed some time to
> settle
> >> > before it is stable again.
> >> >
> >> > Does someone want to pick up 2 say by the end of week or next week to
> fix
> >> > all headers?
> >> >
> >> > - Bolke
> >> >
> >> >
> >> > > Op 14 jun. 2016, om 20:01 heeft Maxime Beauchemin <
> >> > maximebeauchemin@gmail.com> het volgende geschreven:
> >> > >
> >> > > I think (1) is good to go. I can cherry pick it into our production
> to
> >> > make
> >> > > sure it's ready for release.
> >> > >
> >> > > (2) should be fine, git should be able to merge easily, otherwise
> it's
> >> > > super easy to resolve any conflicts
> >> > >
> >> > > Max
> >> > >
> >> > > On Tue, Jun 14, 2016 at 9:04 AM, Chris Riccomini <
> >> criccomini@apache.org>
> >> > > wrote:
> >> > >
> >> > >> Hey Bolke,
> >> > >>
> >> > >> I think your list is good. (1) is what I'm most concerned about,
> as it
> >> > >> requires actually touching the code, and is blocking on
> graduation. I
> >> > >> *think* Max had a partial PR on that, but don't know the current
> >> state.
> >> > >>
> >> > >> Re: (2), agree. Should just do a bulk PR for it.
> >> > >>
> >> > >> Cheers,
> >> > >> Chris
> >> > >>
> >> > >> On Tue, Jun 14, 2016 at 8:41 AM, Bolke de Bruin <bdbruin@gmail.com
> >
> >> > wrote:
> >> > >>
> >> > >>> Hi,
> >> > >>>
> >> > >>> I am wondering what needs to be done to get to an Apache release?
> I
> >> > think
> >> > >>> now 1.7.1.3 is out we should be focused on getting one out
as we
> are
> >> > kind
> >> > >>> of half way the incubation process. What comes to my mind
is:
> >> > >>>
> >> > >>> 1. Replace highcharts by D3 (WIP:
> >> > >>> https://github.com/apache/incubator-airflow/pull/1469)
> >> > >>> 2. Add license headers everywhere (TM) (Sucks, as it will
break
> many
> >> > PRs
> >> > >> -
> >> > >>> but lets do it quickly)
> >> > >>> 3. Have a review by Apache
> >> > >>>
> >> > >>> Anything I am missing?
> >> > >>>
> >> > >>> - Bolke
> >> > >>
> >> >
> >> >
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message