airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bolke de Bruin <bdbr...@gmail.com>
Subject Re: Splitting models.py
Date Thu, 02 Jun 2016 13:34:17 GMT
Mmm it does look like a "how to screw yourself" email :-). 

A refactor would be welcome. If we are going to break PRs why not do a "add license" exercise
and "replace high charts" exercise in one go?


B


Sent from my iPhone

> On 2 jun. 2016, at 15:03, Jeremiah Lowin <jlowin@apache.org> wrote:
> 
> Models.py is becoming monolithic. We've discussed refactoring it many
> times. No way around this: refactoring it will suck. It will break PRs and
> require rebases. It will make it impossible to see diffs.
> 
> On the other hand it will make future changes much more manageable. It will
> implicitly address concerns about PRs that touch "core" areas because we'll
> be able to see if "dags.py" is altered, as opposed to "xcom.py". It will
> make the codebase more digestible and clear.
> 
> I'm not exactly lining up to champion this but it will only get harder and
> harder to do so I want to raise the issue to the list...
> 
> J

Mime
View raw message