airflow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From siddharth anand <r39...@gmail.com>
Subject Re: [DISCUSS] Review-then-commit (RTC) vs Commit-then-review (CTR)
Date Fri, 20 May 2016 16:23:37 GMT
Can we suggest a +1 vote for non-minor/non-trivial commits, or do all
commits require a +1? Or is the "non-minor, non-trivial" wording too
nebulous. t feels like this would work better the more committers we have
given our different daily work schedules.

-s

On Thu, May 19, 2016 at 5:56 PM, Jakob Homan <jghoman@gmail.com> wrote:

> On 18 May 2016 at 16:06, siddharth anand <r39132@gmail.com> wrote:
> > Is there an automation we can use to ensure/enforce that PRs
> > and JIRAs receive the +1 binding (from committers) votes needed before a
> > merge can proceed
>
> Not that I know of.  Since we're using github PRs, there might be some
> kind of workflow system that plugs into that, but I'm not aware of it.
> Honor code works well, and reverting commits work when it doesn't...
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message