airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] jedcunningham commented on a change in pull request #15557: Serve logs with Scheduler when using Local or Sequential Executor
Date Wed, 28 Apr 2021 22:10:06 GMT

jedcunningham commented on a change in pull request #15557:
URL: https://github.com/apache/airflow/pull/15557#discussion_r622599685



##########
File path: airflow/cli/commands/scheduler_command.py
##########
@@ -30,6 +32,8 @@
 @cli_utils.action_logging
 def scheduler(args):
     """Starts Airflow Scheduler"""
+    skip_serve_logs = args.skip_serve_logs

Review comment:
       Ah, consistency with worker makes sense. I don't have a strong opinion here, just when
looking at scheduler in isolation the default seems backwards to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message