From commits-return-169745-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Mar 1 17:44:35 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 5557718062C for ; Mon, 1 Mar 2021 18:44:35 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 83EA242843 for ; Mon, 1 Mar 2021 17:44:34 +0000 (UTC) Received: (qmail 85065 invoked by uid 500); 1 Mar 2021 17:44:34 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 85056 invoked by uid 99); 1 Mar 2021 17:44:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Mar 2021 17:44:34 +0000 From: =?utf-8?q?GitBox?= To: commits@airflow.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bairflow=5D_pgillet_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=2314028=3A_Reuse_private=5Fkey=5Fpassphrase_from_SSHHook_?= =?utf-8?q?super_class?= Message-ID: <161462067418.15632.11305289579730016766.asfpy@gitbox.apache.org> Date: Mon, 01 Mar 2021 17:44:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: pgillet commented on a change in pull request #14028: URL: https://github.com/apache/airflow/pull/14028#discussion_r584920765 ########## File path: airflow/providers/ssh/hooks/ssh.py ########## @@ -131,9 +132,9 @@ def __init__( # pylint: disable=too-many-statements self.key_file = extra_options.get("key_file") private_key = extra_options.get('private_key') - private_key_passphrase = extra_options.get('private_key_passphrase') + self.private_key_passphrase = extra_options.get('private_key_passphrase') if private_key: - self.pkey = self._pkey_from_private_key(private_key, passphrase=private_key_passphrase) + self.pkey = self._pkey_from_private_key(private_key, passphrase=self.private_key_passphrase) Review comment: :heavy_check_mark: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org