airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] pgillet commented on a change in pull request #14028: Reuse private_key_passphrase from SSHHook super class
Date Mon, 01 Mar 2021 17:44:34 GMT

pgillet commented on a change in pull request #14028:
URL: https://github.com/apache/airflow/pull/14028#discussion_r584920765



##########
File path: airflow/providers/ssh/hooks/ssh.py
##########
@@ -131,9 +132,9 @@ def __init__(  # pylint: disable=too-many-statements
                     self.key_file = extra_options.get("key_file")
 
                 private_key = extra_options.get('private_key')
-                private_key_passphrase = extra_options.get('private_key_passphrase')
+                self.private_key_passphrase = extra_options.get('private_key_passphrase')
                 if private_key:
-                    self.pkey = self._pkey_from_private_key(private_key, passphrase=private_key_passphrase)
+                    self.pkey = self._pkey_from_private_key(private_key, passphrase=self.private_key_passphrase)

Review comment:
       :heavy_check_mark: Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message