airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] turbaszek commented on a change in pull request #12184: Create DAG-level cluster policy
Date Mon, 09 Nov 2020 20:23:19 GMT

turbaszek commented on a change in pull request #12184:
URL: https://github.com/apache/airflow/pull/12184#discussion_r520097076



##########
File path: UPDATING.md
##########
@@ -50,6 +50,14 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Rename policy to task_policy
+
+Because Airflow introduced DAG level policy (`dag_policy`) we decided to rename existing
`policy`
+function to `task_policy` to make the distinction more profound and avoid any confusion.
+
+Users using cluster policy need to rename their `policy` functions in `airflow_local_settings.py`
+to `task_policy`.

Review comment:
       I think this information creates no confusion - users have to take an action (now or
latter). The sooner the better in my opinion. Imho we should encourage users to adjust. However,
if you thing this may create some doubts then I can change the entry. But it will have to
be adjusted once we remove the deprecation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message