From commits-return-88466-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Fri Jan 10 14:03:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A139180657 for ; Fri, 10 Jan 2020 15:03:56 +0100 (CET) Received: (qmail 69941 invoked by uid 500); 10 Jan 2020 14:03:55 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 69932 invoked by uid 99); 10 Jan 2020 14:03:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jan 2020 14:03:55 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] sarutak commented on a change in pull request #7128: [AIRFLOW-6529] Serialization error occurs when the scheduler tries to run on macOS. Message-ID: <157866503541.28808.13945946832099611034.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 10 Jan 2020 14:03:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sarutak commented on a change in pull request #7128: [AIRFLOW-6529] Serialization error occurs when the scheduler tries to run on macOS. URL: https://github.com/apache/airflow/pull/7128#discussion_r365247356 ########## File path: tests/test_utils/mock_executor.py ########## @@ -36,10 +36,17 @@ def __init__(self, do_update=True, *args, **kwargs): self.history = [] # All the tasks, in a stable sort order self.sorted_tasks = [] - self.mock_task_results = defaultdict(lambda: State.SUCCESS) + + # If multiprocessing runs in spawn mode, + # arguments are to be pickled but lambda is not picclable. + # So we should pass self.success instead of lambda. Review comment: Someone might want to try to replace [this](https://github.com/apache/airflow/pull/7128/files#diff-d7e6d11bfaeca087149ad577dd7704daR43) with lambda. Do you have any other idea to avoid that without this note? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services