airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ktmud opened a new pull request #7088: AIRFLOW-6494: SSH host_proxy has to be fresh
Date Tue, 07 Jan 2020 00:48:58 GMT
ktmud opened a new pull request #7088: AIRFLOW-6494: SSH host_proxy has to be fresh
URL: https://github.com/apache/airflow/pull/7088
 
 
   AIRFLOW-1762 moved `host_proxy` in contrib/hooks/ssh_hook.py to _init_, which causes the
proxy socket to be closed whenever the SSH client is closed—which happens every time when
exiting `with get_conn() as client`.
   
   The inconsistency between SSH Client and ProxyCommand's lifecycles would result in "Broken
Pipe" error (because the proxy socket has already been closed!) when the same hook instance
is used multiple time (often needed in some custom operators).
   
   This commit also clean up some parameter parsing logic and allows
   proxy_command to be added in extra_options.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message