airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6507) Replace the use of impl.load_source with another solution.
Date Wed, 08 Jan 2020 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010507#comment-17010507
] 

ASF GitHub Bot commented on AIRFLOW-6507:
-----------------------------------------

sarutak commented on pull request #7099: [AIRFLOW-6507] Replace the use of impl.load_source
with another solution.
URL: https://github.com/apache/airflow/pull/7099
 
 
   As of Python 3.4, impl module will be deprecated and recommended to use importlib.
   Almost all the part of code in Airflow uses importlib except for impl.load_source in models/dagbag.py.
   This change propose a solution that use `importlib.SourceFileLoader`.
   
   I didn't add new test-case because existing test-cases in `TestDagBag` covers.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace the use of impl.load_source with another solution.
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-6507
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6507
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: models
>    Affects Versions: 1.10.8
>            Reporter: Kousuke Saruta
>            Assignee: Kousuke Saruta
>            Priority: Minor
>
> As of Python 3.4, impl module will be deprecated and recommended to use importlib.
> Almost all the part of code in Airflow uses importlib except for impl.load_source in
models/dagbag.py.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message