airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6490) Improve time delta comparison in local task job tests
Date Mon, 06 Jan 2020 18:20:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009074#comment-17009074
] 

ASF GitHub Bot commented on AIRFLOW-6490:
-----------------------------------------

nuclearpinguin commented on pull request #7083: [AIRFLOW-6490] Improve time delta comparison
in local task job tests
URL: https://github.com/apache/airflow/pull/7083
 
 
   This PR eliminates small flakiness from local task job that occurs when something happens
faster"
   ```
   AssertionError: 1.996401 not greater than or equal to 2
   ```
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve time delta comparison in local task job tests
> -----------------------------------------------------
>
>                 Key: AIRFLOW-6490
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6490
>             Project: Apache Airflow
>          Issue Type: Test
>          Components: tests
>    Affects Versions: 1.10.8
>            Reporter: Tomasz Urbaszek
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message