airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6417) Disable approval requirements from mergeable bot
Date Wed, 01 Jan 2020 11:41:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006385#comment-17006385
] 

ASF GitHub Bot commented on AIRFLOW-6417:
-----------------------------------------

mik-laj commented on pull request #6990: [AIRFLOW-6417] Disable approval requirements from
mergeable
URL: https://github.com/apache/airflow/pull/6990
 
 
   I review PR that are in good condition in the first place - they have a green label next
to the title. Unfortunately, now all PRs are always red before they are accepted. When accepted,
they are often merged immediately, so all open PRs are always red. This useful indicator now
makes no sense.
   
   <img width="976" alt="Screenshot 2020-01-01 at 12 32 07" src="https://user-images.githubusercontent.com/12058428/71640926-bfecc000-2c93-11ea-8d2f-84520c273c33.png">
   
   In my opinion, we do not have a problem with merging PRs that are not accepted, so this
option does not solve any of our problems. 
   
   
   - [X] Description above provides context of the change
   - [X] Commit message contains [\[AIRFLOW-6417\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX)
or `[AIRFLOW-6417]` for document-only changes
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Disable approval requirements from mergeable bot
> ------------------------------------------------
>
>                 Key: AIRFLOW-6417
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6417
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.10.7
>            Reporter: Kamil Bregula
>            Priority: Major
>         Attachments: Screenshot 2020-01-01 at 12.32.07.png, image-2020-01-01-12-32-24-188.png,
image-2020-01-01-12-32-25-491.png
>
>
> I review PR that are in good condition in the first place - they have a green label next
to the title. Unfortunately, now all PRs are always red before they are accepted. When accepted,
they are often merged immediately, so all open PRs are always red. This useful indicator now
makes no sense.
>  !Screenshot 2020-01-01 at 12.32.07.png! 
> In my opinion, we do not have a big problem with merging PRs that are not accepted, so
this option does not solve any of our problems.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message