airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6416) Remove DB provide_session and sort by conn_id
Date Wed, 01 Jan 2020 08:27:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006339#comment-17006339
] 

ASF GitHub Bot commented on AIRFLOW-6416:
-----------------------------------------

zhongjiajie commented on pull request #6987: [AIRFLOW-6416] Remove DB provide_session and
sort by conn_id
URL: https://github.com/apache/airflow/pull/6987
 
 
   * Remove unnecessary annotation provide_session
   * Sort create_default_connections by connection id
   * Add sort connection id unittest
   
   - [x] Description above provides context of the change
   - [x] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-6416)
or `[AIRFLOW-6416]` for document-only changes
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove DB provide_session and sort by conn_id
> ---------------------------------------------
>
>                 Key: AIRFLOW-6416
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6416
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: database
>    Affects Versions: 1.10.7
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Major
>
> Remove DB provide_session and sort by conn_id
> * Remove unnecessary annotation provide_session
> * Sort create_default_connections by connection id
> * Add sort connection id unittest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message