airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] feluelle commented on a change in pull request #6075: [AIRFLOW-5266] Allow aws_athena_hook to get all query results
Date Tue, 14 Jan 2020 18:56:35 GMT
feluelle commented on a change in pull request #6075: [AIRFLOW-5266] Allow aws_athena_hook
to get all query results
URL: https://github.com/apache/airflow/pull/6075#discussion_r366514619
 
 

 ##########
 File path: tests/contrib/hooks/test_aws_athena_hook.py
 ##########
 @@ -0,0 +1,88 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# 'License'); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import unittest
+from unittest import mock
+
+try:
+    from airflow.contrib.hooks.aws_athena_hook import AWSAthenaHook
+except ImportError:
+    AWSAthenaHook = None  # type: ignore
+
+
+class MockAthenaClient:
 
 Review comment:
   Actually you only need to add `mock_conn.get_query_results.return_value = self.base_query_result`
to the beginning of the test function. That is basically what you are already doing.
   
   You are doing good actually. But I would remove the extra class.
   This part
   ```
           if NextToken is None:
               return self.query_result_with_next
           else:
               return self.base_query_result
   ```
   is logic that you don't need if you set the `mock_conn.get_query_results.return_value`
directly in the test function.
   
   Do you understand what I mean? :D

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message