airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] lucafuji commented on a change in pull request #6870: [AIRFLOW-578] Fix check return code
Date Mon, 13 Jan 2020 21:27:51 GMT
lucafuji commented on a change in pull request #6870: [AIRFLOW-578] Fix check return code
URL: https://github.com/apache/airflow/pull/6870#discussion_r366037407
 
 

 ##########
 File path: airflow/utils/state.py
 ##########
 @@ -122,3 +122,10 @@ def unfinished(cls):
             cls.UP_FOR_RETRY,
             cls.UP_FOR_RESCHEDULE
         ]
+
+    @classmethod
+    def unsuccessful(cls):
+        """
+        A list of states indicating that a task completed unsuccessfully.
+        """
+        return [cls.FAILED, cls.UP_FOR_RETRY, cls.UP_FOR_RESCHEDULE]
 
 Review comment:
   UP_FOR_RESCHEDULE is actually added per your comment 24 days ago.
   "Up for reschedule too."
   So please let me know what's your thought so I can make a final change. 
   
   IMO,  UP_FOR_RESCHEDULE should not be treated as a unsuccessful state as you describe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message