airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] zhongjiajie commented on a change in pull request #7148: [AIRFLOW-6472] Correct short option in cli
Date Mon, 13 Jan 2020 16:44:48 GMT
zhongjiajie commented on a change in pull request #7148: [AIRFLOW-6472] Correct short option
in cli
URL: https://github.com/apache/airflow/pull/7148#discussion_r365908093
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -102,7 +102,7 @@ class CLIFactory:
             ("-e", "--end_date"), "Override end_date YYYY-MM-DD",
             type=parsedate),
         'dry_run': Arg(
-            ("-dr", "--dry_run"), "Perform a dry run", "store_true"),
+            ("-d", "--dry_run"), "Perform a dry run", "store_true"),
 
 Review comment:
   :+1: `-n` is the better choose, but what I talk in this comment is should we use `--dry-run`
to replace `--dry_run`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message