airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
Date Sat, 11 Jan 2020 21:42:30 GMT
potiuk commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573357010
 
 
   > Actually there are some tests in the test_databricks_operator.py file:
   > line 278:
   > `test_init_with_json()` method (already updated in this PR) the job_id is not passed
directly, and it is in the json dict in this test.
   > Does it like the "one with the default param from json" or what kind of test should
I implement other than this?
   > line 267:
   > `test_init_with_named_parameters()` job_id is not in the json, it passed directly.

   
   That's a very good point :). I missed this test entirely. It's good to go !
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message