airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.
Date Wed, 08 Jan 2020 21:15:40 GMT
kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source
with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364446643
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, safe_mode=True):
 
             with timeout(self.DAGBAG_IMPORT_TIMEOUT):
                 try:
-                    m = imp.load_source(mod_name, filepath)
+                    loader = importlib.machinery.SourceFileLoader(mod_name, filepath)
+                    spec = importlib.util.spec_from_loader(mod_name, loader)
+                    m = importlib.util.module_from_spec(spec)
+                    sys.modules[spec.name] = m
 
 Review comment:
   The following should also work:
   
   ```python
   spec = importlib.util.spec_from_file_location(module_name, module_path)
   module = importlib.util.module_from_spec(spec)
   spec.loader.exec_module(module
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message