airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] dstandish commented on issue #6850: [AIRFLOW-6296] add mssql odbc hook
Date Tue, 07 Jan 2020 19:18:00 GMT
dstandish commented on issue #6850: [AIRFLOW-6296] add mssql odbc hook
URL: https://github.com/apache/airflow/pull/6850#issuecomment-571730566
 
 
   > One of the things I'd like to support is to directly pass in the ODBC connection string
   
   @vamega the present design supports this :)
   
   You can get some details from [the doc](https://github.com/apache/airflow/blob/806b33247c15d6410432537b32cb27c6d0bd597c/docs/howto/connection/mssql_odbc.rst).
   
   Looking at [the tests](https://github.com/apache/airflow/blob/806b33247c15d6410432537b32cb27c6d0bd597c/tests/providers/mssql/hooks/test_mssql_odbc.py)
also demonstrates expected behavior.
   
   I don't like having to mess with odbc.ini either.  I want to support usage of DSN but not
require it.
   
   The basic approach though is this:
   * user / password / host / database / port are obtained from standard `Connection` attributes

   * any odbc params supplied in `Connection.extra` will be added to connection string
   * kwargs meant for `pyodbc.connect` can be supplied under key `connect_kwargs` in extra
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message