airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Date Tue, 07 Jan 2020 17:41:28 GMT
kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs
when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363867286
 
 

 ##########
 File path: airflow/serialization/serialized_objects.py
 ##########
 @@ -253,7 +253,8 @@ def _value_is_hardcoded_default(cls, attrname: str, value: Any) ->
bool:
         default. (This is because ``"default" is "default"`` will be False as
         they are different strings with the same characters.)
         """
-        if attrname in cls._CONSTRUCTOR_PARAMS and cls._CONSTRUCTOR_PARAMS[attrname].default
is value:
+        if attrname in cls._CONSTRUCTOR_PARAMS and \
+                (cls._CONSTRUCTOR_PARAMS[attrname].default is value or (value in [{}, []])):
 
 Review comment:
   No it is excluded because of the following function:
   
   https://github.com/apache/airflow/blob/e6f2e19912a1c588c79bb8ac137d09d6789d8126/airflow/serialization/serialized_objects.py#L107-L114

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message